C#: SubmitDocumentAsync and the shard write forwarder complete on the result frame #58

Merged

libby merged 1 commit from libby/cs-client-ack-finding into main 2026-11-08 13:24:39 +00:00

Conversation 0 Commits 1 Files changed 10 +232 -6

libby commented 2026-11-08 13:24:34 +00:00

Member

Copy link

C#: SubmitDocumentAsync and the shard write forwarder (CultNetSchemaWriteForwarder.ForwardPutAsync/ForwardDeleteAsync) complete on the peer's result frame, not on the send returning. New CultNetWriteCompletion.SendAndAwaitResultAsync registers the refusal handler before the send and waits a result window (500 ms default; CultMeshClientOptions.SubmitResultWindow, CultNetSchemaWriteForwarderOptions.ResultWindow). A cultnet.error.v0 in the window rejects with the new CultNetWriteRefusedException (Code: write_not_authorized, message_invalid, ...) whatever its order against the send or transport ack. Peers send no success frame for an admitted write, so the window is the interim bound (no server code); the error frame carries no message id, so any refusal inside the window is attributed to this write.

Caller exposure: CultNetDatabaseServer.TryForwardPutAsync/DeleteAsync (:698/:718) returned true after a forward whose refusal it never read; a refused forward now throws from the forwarder, the same path as an unreachable primary (server code unchanged).

Doc line 'fire-and-forget: an ack or a return is not admission; read the result frame' on the C# ICultNetSchemaClient.SendCultNet and CultMeshSession.SendCultNet, Python CultNetRawClient.send and the RUDP/tcp transport send, Kotlin sendSchemaMessage/send/sendSchema.

Tests: SubmitDocument and forwarder reject typed for write_not_authorized and message_invalid, immediate and after 150 ms; neither completes before the window. Mutants killed: refusal check removed, window zeroed, handler registered after the send. Mesh.Tests 346 and Networking.Tests 514 pass.

🤖 Generated with Claude Code

C#: `SubmitDocumentAsync` and the shard write forwarder (`CultNetSchemaWriteForwarder.ForwardPutAsync/ForwardDeleteAsync`) complete on the peer's result frame, not on the send returning. New `CultNetWriteCompletion.SendAndAwaitResultAsync` registers the refusal handler before the send and waits a result window (500 ms default; `CultMeshClientOptions.SubmitResultWindow`, `CultNetSchemaWriteForwarderOptions.ResultWindow`). A `cultnet.error.v0` in the window rejects with the new `CultNetWriteRefusedException` (`Code`: `write_not_authorized`, `message_invalid`, ...) whatever its order against the send or transport ack. Peers send no success frame for an admitted write, so the window is the interim bound (no server code); the error frame carries no message id, so any refusal inside the window is attributed to this write. Caller exposure: `CultNetDatabaseServer.TryForwardPutAsync/DeleteAsync` (:698/:718) returned true after a forward whose refusal it never read; a refused forward now throws from the forwarder, the same path as an unreachable primary (server code unchanged). Doc line 'fire-and-forget: an ack or a return is not admission; read the result frame' on the C# `ICultNetSchemaClient.SendCultNet` and `CultMeshSession.SendCultNet`, Python `CultNetRawClient.send` and the RUDP/tcp transport `send`, Kotlin `sendSchemaMessage`/`send`/`sendSchema`. Tests: SubmitDocument and forwarder reject typed for write_not_authorized and message_invalid, immediate and after 150 ms; neither completes before the window. Mutants killed: refusal check removed, window zeroed, handler registered after the send. Mesh.Tests 346 and Networking.Tests 514 pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

libby added 1 commit 2026-11-08 13:24:34 +00:00

C#: SubmitDocumentAsync and the shard write forwarder complete on the result frame ... 09e6a528b8

CultNetWriteCompletion.SendAndAwaitResultAsync registers a refusal handler before
the send, then waits a result window (default 500 ms; CultMeshClientOptions.
SubmitResultWindow, CultNetSchemaWriteForwarderOptions.ResultWindow). A
cultnet.error.v0 inside it rejects with the new CultNetWriteRefusedException
(Code: write_not_authorized, message_invalid, ...) whatever its order against the
send or transport ack; a send returning no longer completes the write. The
forwarder's refusal now throws on the same path as an unreachable primary, so
CultNetDatabaseServer.TryForwardPutAsync/DeleteAsync no longer report a refused
forward as done. Raw send primitives (C# schema client/session, Python, Kotlin)
carry the doc line: fire-and-forget, an ack or a return is not admission, read the
result frame.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

libby merged commit dc5abedffc into main 2026-11-08 13:24:39 +00:00

libby referenced this pull request from a commit 2026-11-08 13:24:40 +00:00

Merge pull request 'C#: SubmitDocumentAsync and the shard write forwarder complete on the result frame' (#58) from libby/cs-client-ack-finding into main

libby referenced this pull request 2026-11-08 13:28:47 +00:00

spec: cultnet write receipt (write_admitted, error id echo, admitted/refused/unconfirmed) #59

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/CultLib!58

No description provided.