GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

sln: drop EveBrowserNetworkSample so dotnet build CultLib.sln succeeds #22

Merged
libby merged 1 commit from libby/drop-eve-sample into main 2026-11-07 11:33:13 +00:00
Conversation 0 Commits 1 Files changed 1 -17
libby commented 2026-11-07 11:32:13 +00:00
Member
Copy link

dotnet build CultLib.sln failed on a fresh checkout. The only error (grep -c "error CS" counts 2 lines, one error reported twice):

samples/eve-browser-network/Program.cs(6,16): error CS0234: The type or namespace name 'Eve' does not exist in the namespace 'GameCult'

EveBrowserNetworkSample.csproj ProjectReferences ../../../Eve/packages/org.gamecult.eve.surface, which is not checked out beside CultLib (restore logged Skipping project ... because it was not found). Eve is deprecated.

Change

CultLib.sln only (-17 lines): the sample's project entry, its configuration lines, and the now-empty samples solution folder. Made with dotnet sln remove. The sample stays on disk, and scripts/verify-eve-browser-network.mjs --eve-root <Eve> still builds it on its own.

Local build (CI runners are stuck)

Before, at origin/main 824a1545: Build FAILED. with the error above.
After, at this branch:

dotnet build CultLib.sln
Build succeeded.
    29 Warning(s)
    0 Error(s)
Time Elapsed 00:00:05.58

(dotnet 10.0.403; second build on a warm tree, so the 5s is incremental.)

Docs check

No doc says the sample is in the solution. README lines 39 and 179-185 say to build the solution, which now works. The other mentions (README 54/101, getting-started 01/03/04, browser-verse-transport.md, document-variants-cut.md, cultmesh-browser README, package.json test:eve-browser-network, the two verify scripts) point at the samples/eve-browser-network directory or the script, both of which still exist. Left unchanged. The getting-started pages still send readers to a sample that needs a sibling Eve checkout; that is a docs follow-up for the Eve deprecation, not this fix.

Not merged.

🤖 Generated with Claude Code

`dotnet build CultLib.sln` failed on a fresh checkout. The only error (`grep -c "error CS"` counts 2 lines, one error reported twice): ``` samples/eve-browser-network/Program.cs(6,16): error CS0234: The type or namespace name 'Eve' does not exist in the namespace 'GameCult' ``` `EveBrowserNetworkSample.csproj` ProjectReferences `../../../Eve/packages/org.gamecult.eve.surface`, which is not checked out beside CultLib (restore logged `Skipping project ... because it was not found`). Eve is deprecated. ## Change `CultLib.sln` only (-17 lines): the sample's project entry, its configuration lines, and the now-empty `samples` solution folder. Made with `dotnet sln remove`. The sample stays on disk, and `scripts/verify-eve-browser-network.mjs --eve-root <Eve>` still builds it on its own. ## Local build (CI runners are stuck) Before, at origin/main 824a1545: `Build FAILED.` with the error above. After, at this branch: ``` dotnet build CultLib.sln Build succeeded. 29 Warning(s) 0 Error(s) Time Elapsed 00:00:05.58 ``` (dotnet 10.0.403; second build on a warm tree, so the 5s is incremental.) ## Docs check No doc says the sample is in the solution. README lines 39 and 179-185 say to build the solution, which now works. The other mentions (README 54/101, getting-started 01/03/04, browser-verse-transport.md, document-variants-cut.md, cultmesh-browser README, `package.json` `test:eve-browser-network`, the two verify scripts) point at the `samples/eve-browser-network` directory or the script, both of which still exist. Left unchanged. The getting-started pages still send readers to a sample that needs a sibling Eve checkout; that is a docs follow-up for the Eve deprecation, not this fix. Not merged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
sln: drop EveBrowserNetworkSample so dotnet build CultLib.sln succeeds
Some checks failed
CultMesh QUIC native / Build win32-x64 (pull_request) Has been skipped
Details
CultMesh QUIC native / Build linux-x64 (pull_request) Has been skipped
Details
CultMesh QUIC native / Release native binaries (pull_request) Has been skipped
Details
CultMesh portability and performance / ubuntu-latest one-command multiplayer onboarding (pull_request) Failing after 1m1s
Details
CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Failing after 5m45s
Details
CultMesh QUIC native / Verify committed binaries match SHA256SUMS (pull_request) Successful in 41s
Details
7d654cc277 
The sample ProjectReferences ../../../Eve, which is not checked out beside CultLib,
and the only error in the build was Program.cs CS0234 (GameCult.Eve missing).
The sample stays on disk and is built by scripts/verify-eve-browser-network.mjs
with --eve-root; it is just no longer part of the default solution build.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
libby merged commit c17b330d70 into main 2026-11-07 11:33:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/CultLib!22
No description provided.