Single-file readers refuse duplicate keys in all four runtimes; c0 bad-canonical row

libby commented

2026-11-11 14:30:04 +00:00

Member

Closes variants:follow_up:reader-refuses-duplicate-keys and variants:follow_up:c0-bad-canonical-in-manifest.

Every runtime's single-file reader now refuses a store with two records under one key (ordinal string equality, schema not part of identity) as its unreadable-store error, instead of opening it last-wins and failing later writes raw. Five readability vectors (3 refuse, 2 distinct-key read: case, NFC/NFD) and a c0 manifest row (current-catalog-bad-canonical.msgpack, refuse x4; TS and Python no longer coerce a non-string catalog slot 4) are walked by all four runtimes plus the Mesh C# walk.

Writers: TS, Python and Rust writers replaced an arrived record only on (type, key), so they could write a store the new reader refuses; they now replace by key alone. Residual, not in this PR: TS/Py/Rs in-memory caches are still keyed by type+key (see leaf-key-identity-parity), so one batch carrying two types under one key can still write a duplicate-key file in TS and Python (Rust keeps the last).

Cut reports: cut-reader-dup-keys-{vectors,csharp,rust,ts,python}.h1, cut-c0-bad-canonical-row.h1/.h2.

🤖 Generated with Claude Code

Closes variants:follow_up:reader-refuses-duplicate-keys and variants:follow_up:c0-bad-canonical-in-manifest. Every runtime's single-file reader now refuses a store with two records under one key (ordinal string equality, schema not part of identity) as its unreadable-store error, instead of opening it last-wins and failing later writes raw. Five readability vectors (3 refuse, 2 distinct-key read: case, NFC/NFD) and a c0 manifest row (`current-catalog-bad-canonical.msgpack`, refuse x4; TS and Python no longer coerce a non-string catalog slot 4) are walked by all four runtimes plus the Mesh C# walk. Writers: TS, Python and Rust writers replaced an arrived record only on (type, key), so they could write a store the new reader refuses; they now replace by key alone. Residual, not in this PR: TS/Py/Rs in-memory caches are still keyed by type+key (see leaf-key-identity-parity), so one batch carrying two types under one key can still write a duplicate-key file in TS and Python (Rust keeps the last). Cut reports: cut-reader-dup-keys-{vectors,csharp,rust,ts,python}.h1, cut-c0-bad-canonical-row.h1/.h2. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

libby added 11 commits

2026-11-11 14:30:04 +00:00

vectors: duplicate-key stores are unreadable; keys are ordinal a8597070ea

Three dup-key vectors (same schema, other schema, different payload) refuse in all
four runtimes; case and NFC/NFD distinct-key vectors read. Runtimes not yet cut: the
dup rows are red until the runtime cuts land.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-py: refuse duplicate record keys and non-string canonical schema; writer replaces by key 9f869adb60

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-ts: decodeSnapshot refuses two records under one key; push replaces by key fc03ab48ba

The reader owns the verdict; the writer replaces an arrived record by key alone so it cannot emit a store the reader refuses. Store-file tests no longer pin one key under two types.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-ts: a present non-string canonical schema slot is refused; c0 bad-canonical joins the readability manifest e8d5d35f07

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-rs: a store holding two records under one key is unreadable; the writer keeps one record per key 07d77c0b22

decode_store_snapshot refuses a repeated key (Undecodable). SingleFile push and push_all
replaced by (type,key), so a write of another type to an existing key left two records
under one key, which the reader now refuses; they now replace by key alone.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

csharp: the one store reader refuses two records under one key 73398ea50b

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/hands/reader-dup-keys-vectors' into reader-dup-keys 2ba3d56e1c

Merge remote-tracking branch 'origin/hands/reader-dup-keys-csharp' into reader-dup-keys 823ed52f53

Merge remote-tracking branch 'origin/hands/reader-dup-keys-rust' into reader-dup-keys d09f8be886

Merge remote-tracking branch 'origin/hands/reader-dup-keys-ts' into reader-dup-keys d361a53ab9

Merge remote-tracking branch 'origin/hands/reader-dup-keys-python' into reader-dup-keys

CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Has been cancelled

Details

0378b9160a

libby added 6 commits

2026-11-11 14:47:16 +00:00

Add legacy-dup-key readability vector: legacy envelope array with key a under two types bacde9fb8e

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-py: refuse a legacy duplicate key; refuse a write that would retype a key 3379191b00

The legacy envelope-array decoder refuses a duplicate key as v1 does. The single-file writer
refuses (SchemaConflictError, C# Retyped wording) a put/push_all that would land a second type
under a key the store holds or the batch already names; file unchanged. Replace-by-key stays
for the same type. Retyping is remove-then-add.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-rs: refuse a second type under a held key; legacy arrays refuse duplicate keys 9da139bf09

A single-file store holds one record per key. push and push_all now refuse (SchemaConflictError) a write that would put another type under a key, leaving file and cache unchanged, within one batch too; the legacy envelope-array decoder refuses a duplicate key like v1. Retyping is remove-then-add.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-ts: refuse a duplicate key in a legacy envelope array; refuse a second type under a stored key on push and pushAll 6c4d9f81d1

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/hands/reader-dup-keys-fix-py' into reader-dup-keys e2f84271c7

Merge remote-tracking branch 'origin/hands/reader-dup-keys-fix-rs' into reader-dup-keys

CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Has been cancelled

Details

fa5903facf

libby added 3 commits

2026-11-11 15:02:14 +00:00

cultcache-ts: pushAll keeps the last of same-type entries sharing a key e260b72697

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-rs: one commit guard for single-file writes refuses a second type under a held key 221d514b09

write_all_unlocked now refuses any snapshot holding a key twice (SchemaConflictError for two types), so insert_entry_if_absent, the compare-and-swap family, compare_exchange and the snapshot exchanges cannot bypass it; push and push_all lose their private copies.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/hands/reader-dup-keys-fix-rs' into reader-dup-keys

CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Successful in 25m31s

Details

7ecb887d47

libby merged commit 4246a37284 into main

2026-11-11 15:07:49 +00:00

libby referenced this pull request from a commit

2026-11-11 15:07:49 +00:00

Single-file readers refuse duplicate keys in all four runtimes; c0 bad-canonical row (#110)

libby referenced this pull request from a commit

2026-11-11 15:14:46 +00:00

cultcache-rs: retype refusal asks schema-id ownership; compare_and_swap_entry refuses in-place retype; push_all last-wins pinned; changelog for #110