Old-reader probes: a reader from before element ids refuses the v3 header

old-reader-refusal.sh stages the C0 merge (e382bb4, or OLD_READER_REV) plus the v3 vector
and one probe per runtime onto a commit; the probe run from that tree is the old reader.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-29 18:27:17 +02:00
commit f4f8e3ed93
5 changed files with 135 additions and 0 deletions

View file

@ -0,0 +1,34 @@
#nullable enable
using System;
using System.IO;
using GameCult.Caching;
using GameCult.Caching.MessagePack;
using NUnit.Framework;
namespace GameCult.Caching.Tests
{
// Copied into a checkout of the C0 merge (e382bb4) by old-reader-refusal.sh. Not part of this tree's suite.
public class OldReaderV3Probe
{
[Test]
public void ACopyOfV3BaseIsRefusedByHeader()
{
var root = Path.Combine(Path.GetTempPath(), $"cultlib-oldreader-{Guid.NewGuid():N}");
Directory.CreateDirectory(root);
try
{
var file = Path.Combine(root, "store.msgpack");
File.Copy(Path.Combine(Environment.GetEnvironmentVariable("CULTLIB_ROOT")!, "tests", "vectors", "document-variants-c2a", "v3-base.msgpack"), file);
using var cache = new CultCache();
var error = Assert.Catch(() => cache.AddBackingStore(new SingleFileMessagePackBackingStore(file)));
Assert.That(error, Is.Not.Null);
TestContext.Out.WriteLine("OLD-READER csharp refused: " + error!.Message);
Assert.That(error.ToString(), Does.Contain("cultcache.store.v3"));
}
finally
{
Directory.Delete(root, recursive: true);
}
}
}
}

View file

@ -0,0 +1,18 @@
import assert from "node:assert/strict";
import { mkdtemp, readFile, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join, resolve } from "node:path";
import { test } from "node:test";
import { SingleFileMessagePackBackingStore } from "../src/single-file-messagepack-backing-store";
// Copied into a checkout of the C0 merge (e382bb4) by old-reader-refusal.sh. Not part of this tree's suite.
test("old TypeScript reader refuses the v3 element-id store by header", async () => {
const dir = await mkdtemp(join(tmpdir(), "cultcache-oldreader-"));
const file = join(dir, "store.msgpack");
await writeFile(file, await readFile(resolve(__dirname, "../../../../tests/vectors/document-variants-c2a/v3-base.msgpack")));
await assert.rejects(() => new SingleFileMessagePackBackingStore(file).pullAll(), (error: Error) => {
console.log("OLD-READER typescript refused: " + error.message);
return /cultcache\.store\.v3/u.test(error.message);
});
});

View file

@ -0,0 +1,15 @@
// Copied into a checkout of the C0 merge (e382bb4) by old-reader-refusal.sh. Not part of this tree's suite.
use cultcache_rs::{CacheBackingStore, SingleFileMessagePackBackingStore};
#[test]
fn old_rust_reader_refuses_the_v3_element_id_store_by_header() {
let temp = tempfile::tempdir().unwrap();
let path = temp.path().join("store.msgpack");
let vector = std::path::Path::new(env!("CARGO_MANIFEST_DIR"))
.join("../../tests/vectors/document-variants-c2a/v3-base.msgpack");
std::fs::copy(vector, &path).unwrap();
let error = SingleFileMessagePackBackingStore::new(&path).pull_all().unwrap_err();
let message = format!("{error:#}");
println!("OLD-READER rust refused: {message}");
assert!(message.contains("cultcache.store.v3"), "{message}");
}

View file

@ -0,0 +1,22 @@
import tempfile
import unittest
from pathlib import Path
from cultcache_py import SingleFileMessagePackBackingStore
# Copied into a checkout of the C0 merge (e382bb4) by old-reader-refusal.sh. Not part of this tree's suite.
class OldReaderV3(unittest.TestCase):
def test_old_python_reader_refuses_the_v3_element_id_store_by_header(self) -> None:
vector = Path(__file__).resolve().parents[3] / "tests" / "vectors" / "document-variants-c2a" / "v3-base.msgpack"
with tempfile.TemporaryDirectory() as tmp:
store_path = Path(tmp) / "store.msgpack"
store_path.write_bytes(vector.read_bytes())
with self.assertRaises(ValueError) as caught:
SingleFileMessagePackBackingStore(store_path).pull_all()
print("OLD-READER python refused:", caught.exception)
self.assertIn("cultcache.store.v3", str(caught.exception))
if __name__ == "__main__":
unittest.main()

View file

@ -0,0 +1,46 @@
#!/usr/bin/env bash
# Proves that a reader from before element ids refuses the v3 header, per runtime. The old reader is the code at the C0
# merge (e382bb4), which accepts only cultcache.store.v1; OLD_READER_REV overrides it (the C1 merge, for the C# reader that
# reads v2).
#
# old-reader-refusal.sh stage
# Run in a CultLib clone. Commits the old revision plus the v3 vector and the probes in old-reader-probes/ onto a
# scratch ref and prints its SHA. The tree at that SHA is the old reader with one extra test.
# old-reader-refusal.sh probe csharp|typescript|python|rust
# Run at the root of the staged tree (a verification job given that SHA), with the runtime's toolchain on PATH.
# Exit status zero means the old reader refused the header by name; the refusal message is printed.
set -euo pipefail
case "${1:-}" in
stage)
root="$(git rev-parse --show-toplevel)"
here="tests/vectors/document-variants-c2a"
old="$(mktemp -d)/old"
git -C "$root" worktree add --detach "$old" "${OLD_READER_REV:-e382bb4}" >/dev/null
mkdir -p "$old/$here"
cp "$root/$here/v3-base.msgpack" "$old/$here/"
cp "$root/$here/old-reader-probes/OldReaderV3Probe.cs" "$old/tests/GameCult.Caching.Tests/"
cp "$root/$here/old-reader-probes/old-reader-v3.test.ts" "$old/packages/cultcache-ts/test/"
cp "$root/$here/old-reader-probes/test_old_reader_v3.py" "$old/packages/cultcache-py/tests/"
mkdir -p "$old/packages/cultcache-rs/tests"
cp "$root/$here/old-reader-probes/old_reader_v3.rs" "$old/packages/cultcache-rs/tests/"
git -C "$old" add -A
git -C "$old" commit -q -m "old-reader probe over ${OLD_READER_REV:-e382bb4}"
sha="$(git -C "$old" rev-parse HEAD)"
git -C "$root" update-ref "refs/old-reader-probe/$sha" "$sha"
git -C "$root" worktree remove --force "$old"
echo "$sha" ;;
probe)
case "${2:-}" in
csharp) CULTLIB_ROOT="$PWD" dotnet test tests/GameCult.Caching.Tests --filter FullyQualifiedName~OldReaderV3Probe --logger "console;verbosity=detailed" ;;
typescript)
npm install --no-audit --no-fund >/dev/null 2>&1
cd packages/cultcache-ts
node ../../node_modules/typescript/bin/tsc -p tsconfig.json
node ../../node_modules/typescript/bin/tsc -p tsconfig.test.json
node --test dist-test/test/old-reader-v3.test.js ;;
python) PYTHONPATH=packages/cultcache-py/src python3 packages/cultcache-py/tests/test_old_reader_v3.py -v ;;
rust) cd packages/cultcache-rs && cargo test --test old_reader_v3 -- --nocapture ;;
*) echo "usage: $0 probe csharp|typescript|python|rust" >&2; exit 2 ;;
esac ;;
*) echo "usage: $0 stage | probe <runtime>" >&2; exit 2 ;;
esac