From e8d5d35f07f33213f5e2a5bc96ee2cbbf580521d Mon Sep 17 00:00:00 2001 From: Libby Date: Wed, 11 Nov 2026 14:11:59 +0000 Subject: [PATCH] cultcache-ts: a present non-string canonical schema slot is refused; c0 bad-canonical joins the readability manifest Co-Authored-By: Claude Sonnet 5.5 --- .../src/single-file-messagepack-backing-store.ts | 6 +++++- .../vectors/document-variants-c2a/readability/manifest.txt | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/cultcache-ts/src/single-file-messagepack-backing-store.ts b/packages/cultcache-ts/src/single-file-messagepack-backing-store.ts index cd8abf9c..9bf63932 100644 --- a/packages/cultcache-ts/src/single-file-messagepack-backing-store.ts +++ b/packages/cultcache-ts/src/single-file-messagepack-backing-store.ts @@ -487,12 +487,16 @@ function decodeCatalogEntry(value: unknown): CultCacheSchemaCatalogEntry { throw new Error(`CultCache schema catalog entry "${schemaId}" has invalid members.`); } + if (typeof canonicalSchemaJson !== "string") { + throw new Error(`CultCache schema catalog entry "${schemaId}" has an invalid canonical schema.`); + } + return { schemaId, schemaName, schemaVersion: isNonEmptyString(schemaVersion) ? schemaVersion : `${schemaName}.v1`, contentHash: isNonEmptyString(contentHash) ? contentHash : schemaId, - canonicalSchemaJson: typeof canonicalSchemaJson === "string" ? canonicalSchemaJson : "", + canonicalSchemaJson, compatibleSchemaIds, members: members.map(decodeCatalogMember), }; diff --git a/tests/vectors/document-variants-c2a/readability/manifest.txt b/tests/vectors/document-variants-c2a/readability/manifest.txt index c969004b..96621a10 100644 --- a/tests/vectors/document-variants-c2a/readability/manifest.txt +++ b/tests/vectors/document-variants-c2a/readability/manifest.txt @@ -36,3 +36,4 @@ dup-key-other-schema-v3.bin refuses refuses refuses refuses dup-key-different-payload-v3.bin refuses refuses refuses refuses distinct-keys-case-v3.bin reads reads reads reads distinct-keys-nfd-v3.bin reads reads reads reads +../../document-variants-c0/current-catalog-bad-canonical.msgpack refuses refuses refuses refuses