GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

Rust: the rename fault fires inside replace_file_atomically, at the call a swallowed error would hide

Browse source 
The seam sat before the call, so a mutant that swallowed the real rename's result was invisible to it. It now makes the rename itself fail, on both platforms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-02 21:11:07 +02:00
commit da2b9482e5
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
packages/cultcache-rs/src/lib.rs
View file

@ -3007,9 +3007,7 @@ fn stage_and_replace(mut staged: File, staged_path: &Path, bytes: &[u8], destina
.and_then(|()| staged.sync_all())
.with_context(|| format!("failed to sync {}", staged_path.display()))?;
drop(staged);
injected_write_fault(WriteStep::Rename)
.map_err(anyhow::Error::from)
.and_then(|()| replace_file_atomically(staged_path, destination))
replace_file_atomically(staged_path, destination)
}
/// Releases a lock taken around `result`'s action and returns that result.
@ -3085,7 +3083,7 @@ fn remove_abandoned_staging_files(destination: &Path) -> Result<()> {
#[cfg(unix)]
fn replace_file_atomically(staged: &Path, destination: &Path) -> Result<()> {
fs::rename(staged, destination).with_context(|| {
injected_write_fault(WriteStep::Rename).and_then(|()| fs::rename(staged, destination)).with_context(|| {
format!(
"failed to atomically replace {} with {}",
destination.display(),
@ -3101,6 +3099,8 @@ fn replace_file_atomically(staged: &Path, destination: &Path) -> Result<()> {
MOVEFILE_REPLACE_EXISTING, MOVEFILE_WRITE_THROUGH, MoveFileExW,
};
injected_write_fault(WriteStep::Rename).context("failed to atomically replace the store")?;
let staged_wide = staged
.as_os_str()
.encode_wide()