GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Caching: CacheBackingStore.MarkWritten is an instance method that refuses an entry the store does not hold

Browse source 
A protected static mark let any subclass mark another store's or cache's
entry. The instance form throws ArgumentException unless the entry is the
one this store holds in its own Entries at that key. Both library stores
already mark only their own entries, so their calls are unchanged.

Finding cultlib-gaps:finding:cut-expect-persisted-schema.s2.markwritten-unscoped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-21 21:59:38 +02:00
commit afd799ba8d
1 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/GameCult.Caching/CultCache.cs
View file

@ -393,7 +393,7 @@ namespace GameCult.Caching
/// <summary>
/// The schema id this record is durably stored under, as its backing store last read or wrote it. It differs from
/// <see cref="CultDocumentDescriptor.SchemaId"/> only for a record loaded under compatible schema drift that its
/// store has not rewritten since; a store records its rewrite with <see cref="CacheBackingStore.MarkWritten"/>.
/// store has not rewritten since; a store records its rewrite of an entry it holds with <see cref="CacheBackingStore.MarkWritten"/>.
/// Conditional commit compares this id and <see cref="StoredAt"/> with the disk.
/// </summary>
public string PersistedSchemaId => _persisted.SchemaId;
@ -3331,8 +3331,16 @@ namespace GameCult.Caching
/// kept is not marked. A rewrite left unmarked makes conditional commit compare the schema id the record was read
/// under, which fails closed until the next pull.
/// </summary>
protected static void MarkWritten(CultStoredDocument entry) =>
(entry ?? throw new ArgumentNullException(nameof(entry))).MarkWritten();
/// <exception cref="ArgumentException"><paramref name="entry"/> is not the entry this store holds in
/// <see cref="Entries"/> at its key: a store marks only its own rewrite.</exception>
protected void MarkWritten(CultStoredDocument entry)
{
if (entry == null)
throw new ArgumentNullException(nameof(entry));
if (!Entries.TryGetValue(entry.Key.Value, out var held) || !ReferenceEquals(held, entry))
throw new ArgumentException($"Record '{entry.Key.Value}' is not the entry this store holds; a store marks only what it wrote.", nameof(entry));
entry.MarkWritten();
}
}
public abstract class SingleFileBackingStore : CacheBackingStore