From a2bb0bced471c8243ffbde3226d9a9c6b796a70c Mon Sep 17 00:00:00 2001 From: Libby Date: Mon, 9 Nov 2026 20:19:03 +0000 Subject: [PATCH] cultnet-ts test: wait for loopback datagrams instead of a fixed 100 ms sleep "server mode admits a pinned client that restarts on a new port" asserted the Accept arrived after sleep(100) and failed on the forge runner (ok(accept) undefined, run 894). It now polls for the packet or frame it asserts on, up to 2 s; no assertion changed. Co-Authored-By: Claude Sonnet 5.5 --- .../cultnet-ts/test/rudp-connect-generation.test.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/cultnet-ts/test/rudp-connect-generation.test.ts b/packages/cultnet-ts/test/rudp-connect-generation.test.ts index cea61a6d..883fe638 100644 --- a/packages/cultnet-ts/test/rudp-connect-generation.test.ts +++ b/packages/cultnet-ts/test/rudp-connect-generation.test.ts @@ -367,6 +367,10 @@ async function bind(): Promise { return socket; } const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); +// Wait for a datagram-driven condition rather than guessing how long loopback delivery takes on a loaded runner. +const until = async (condition: () => boolean, limitMs = 2_000) => { + for (let waited = 0; !condition() && waited < limitMs; waited += 10) await sleep(10); +}; test("server mode admits a pinned client that restarts on a new port", async () => { const serverSocket = await bind(); @@ -385,24 +389,24 @@ test("server mode admits a pinned client that restarts on a new port", async () try { const first = session(1); a.send(encodeRudpPacket(first.createConnect(0, enc("join"))), port, "127.0.0.1"); - await sleep(100); + await until(() => atA.some((packet) => packet.packetType === "accept")); const accept = atA.find((packet) => packet.packetType === "accept"); assert.ok(accept); first.receive(accept, 0); a.send(encodeRudpPacket(first.createAckForReceived(accept.sequence)), port, "127.0.0.1"); a.send(encodeRudpPacket(send(first, "hello")), port, "127.0.0.1"); - await sleep(100); + await until(() => frames.length === 1); assert.deepEqual(frames, ["hello"]); const second = session(1); // the process restarted on a new port, pinned b.send(encodeRudpPacket(second.createConnect(0, enc("join"))), port, "127.0.0.1"); - await sleep(100); + await until(() => atB.some((packet) => packet.packetType === "accept")); const acceptB = atB.find((packet) => packet.packetType === "accept"); assert.ok(acceptB, `the restarted client on a new port was not admitted: ${JSON.stringify(atB.map((packet) => packet.packetType))}`); second.receive(acceptB, 1); assert.ok(second.connected); b.send(encodeRudpPacket(send(second, "after")), port, "127.0.0.1"); - await sleep(100); + await until(() => frames.length === 2); assert.deepEqual(frames, ["hello", "after"]); } finally { server.close();