GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CultElementIds: a keyed type is read by key before it is read as a sequence

Browse source 
Classify tested IEnumerable<T> before [MessagePackObject], so a keyed class that
enumerates itself recursed until the stack overflowed during registration (s4,
keyed-enumerable-misclassified), and a keyed class that merely enumerates had its
keyed lists neither judged nor minted. Keyed first: MessagePack writes both by key.
VisitMemberType also stops at a type already on its own through chain, which ends
an unkeyed Node : IEnumerable<Node>.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-15 02:49:18 +02:00
commit 9fd5ae1f09
2 changed files with 69 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/GameCult.Caching/CultElementIds.cs
View file

@ -148,6 +148,10 @@ namespace GameCult.Caching
private static void VisitMemberType(Type documentType, Type owner, MemberInfo member, Type memberType, Type[] through, bool hidden, HashSet<Type> seen, Survey survey, Graph graph)
{
memberType = Nullable.GetUnderlyingType(memberType) ?? memberType;
// A sequence or map whose element is itself (an unkeyed Node : IEnumerable<Node>) ends the type walk here; without
// this it would recurse until the stack overflows.
if (Array.IndexOf(through, memberType) >= 0)
return;
var (kind, inner) = Classify(memberType);
switch (kind)
{
@ -565,8 +569,10 @@ namespace GameCult.Caching
private static readonly ConcurrentDictionary<Type, (Kind Kind, Type Inner)> Classes = new();
// The one recognition of what MessagePack writes for a declared type: registration, Plan, Holds and the codec's id path
// all go through it. Inner is a map's value type, a sequence's element type, or the type itself for an owner.
// The walk's model of a declared type: registration, Plan, Holds and the codec's id path all go through it. A
// [MessagePackObject] or [Union] type is read by key even when it is also IEnumerable<T>; the codec checks, for every type
// on the id path, that MessagePack writes it the way this model reads it, and refuses the document when it does not.
// Inner is a map's value type, a sequence's element type, or the type itself for an owner.
// Leaf a value written whole that holds no element list: strings (an IEnumerable<char> MessagePack writes whole),
// a struct, class or interface with no [MessagePackObject] or [Union] (primitives, enums, float2, DateTime,
// and object, which is untyped on disk).
@ -579,13 +585,15 @@ namespace GameCult.Caching
type = Nullable.GetUnderlyingType(type) ?? type;
if (type == typeof(string))
return (Kind.Leaf, type);
if (IsKeyed(type))
return (Kind.Owner, type);
if (type.IsValueType)
return IsKeyed(type) ? (Kind.Owner, type) : (Kind.Leaf, type);
return (Kind.Leaf, type);
if (MapTypes(type) is { } map)
return (Kind.Map, map.Value);
if (ElementTypeOf(type) is { } element)
return (Kind.Sequence, element);
return IsKeyed(type) ? (Kind.Owner, type) : (Kind.Leaf, type);
return (Kind.Leaf, type);
});
// A type MessagePack serializes by key: [MessagePackObject] or [Union].