From 9e481f59b7f40e855103e2803e8c16620a3c4b7c Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Fri, 2 Oct 2026 20:49:43 +0200 Subject: [PATCH] C#: detect a dangling store link by its reparse-point attribute (Caching has no FileInfo.LinkTarget) Commit 425531d8 does not build. Co-Authored-By: Claude Opus 5.5 --- src/GameCult.Caching/CultCache.cs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/GameCult.Caching/CultCache.cs b/src/GameCult.Caching/CultCache.cs index a9e2f3f0..4b93fc44 100644 --- a/src/GameCult.Caching/CultCache.cs +++ b/src/GameCult.Caching/CultCache.cs @@ -4013,13 +4013,13 @@ namespace GameCult.Caching { FileInfo.Refresh(); // Only nothing at the path is an empty store. A link whose target is gone is a store that cannot be reached. - if (!FileInfo.Exists && FileInfo.LinkTarget == null) + if (!FileInfo.Exists && !PathIsALink()) return null; try { return ReadAllBytesShared(FileInfo.FullName); } - catch (FileNotFoundException ex) when (FileInfo.LinkTarget != null) + catch (FileNotFoundException ex) when (PathIsALink()) { throw new IOException("The store path is a link whose target cannot be reached.", ex); } @@ -4029,6 +4029,15 @@ namespace GameCult.Caching } } + // Something is at the path even when the path cannot be opened: a link keeps the reparse-point attribute whether or not its + // target is there. A path with nothing at it reports no attributes at all (-1). + private bool PathIsALink() + { + FileInfo.Refresh(); + var attributes = FileInfo.Attributes; + return (int)attributes != -1 && (attributes & FileAttributes.ReparsePoint) != 0; + } + private void WriteSnapshot(IEnumerable records, IReadOnlyCollection registered, IReadOnlyCollection arrived, bool holdsElementIds, string? existingHeader, bool wholeStore) { var ordered = records.OrderBy(record => record.Key, StringComparer.Ordinal).ToArray();