From 9c7f326f16c84a989e48013b7b3fba45caec7529 Mon Sep 17 00:00:00 2001 From: Libby Date: Wed, 11 Nov 2026 10:41:23 +0000 Subject: [PATCH] Unique-index vectors: row 25 batch-replaced-by-case; walk collects every failing row; README counts are required asserts Co-Authored-By: Claude Sonnet 5.5 --- .../UniqueIndexVectorTests.cs | 10 +++++++++- tests/vectors/unique-index/README.md | 18 +++++++++++------- tests/vectors/unique-index/refusals.msgpack | Bin 2868 -> 2993 bytes 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/tests/GameCult.Caching.Tests/UniqueIndexVectorTests.cs b/tests/GameCult.Caching.Tests/UniqueIndexVectorTests.cs index e3be8c8f..ef5b0b67 100644 --- a/tests/GameCult.Caching.Tests/UniqueIndexVectorTests.cs +++ b/tests/GameCult.Caching.Tests/UniqueIndexVectorTests.cs @@ -408,6 +408,8 @@ namespace GameCult.Caching.Tests // Rows 23-24: two holders of one value that differ only by case are two holders; a case-folding dedupe would see one. new("batch-holders-by-case", new[] { Open(), Commit(HolderCaseRecords) }, HolderCaseRefusal), new("load-holders-by-case", new[] { Open("holder-case-store.cc") }, HolderCaseRefusal), + // Row 25: the held `a` is replaced only by the exact key `a`, never by `A`. + new("batch-replaced-by-case", new[] { Open(), Commit(Items_(("a", "S"))), Commit(Items_(("A", "S"))) }, HolderCaseRefusal), }; private static byte[] RefusalStoreBytes(Rec[] records) @@ -528,6 +530,7 @@ namespace GameCult.Caching.Tests var count = reader.ReadArrayHeader(); Assert.That(count, Is.EqualTo(Cases.Length)); var walked = 0; + var failed = new List(); for (var i = 0; i < count; i++) { Assert.That(reader.ReadArrayHeader(), Is.EqualTo(3)); @@ -588,6 +591,10 @@ namespace GameCult.Caching.Tests walked++; } + catch (AssertionException failure) + { + failed.Add($"{label}: {failure.Message}"); + } finally { cache?.Dispose(); @@ -595,7 +602,8 @@ namespace GameCult.Caching.Tests } } - Assert.That(walked, Is.EqualTo(24)); + Assert.That(failed, Is.Empty, "rows that failed"); + Assert.That(walked, Is.EqualTo(25)); } } } diff --git a/tests/vectors/unique-index/README.md b/tests/vectors/unique-index/README.md index 621ebe36..3f6fd4e9 100644 --- a/tests/vectors/unique-index/README.md +++ b/tests/vectors/unique-index/README.md @@ -51,20 +51,24 @@ last succeeds and the last refuses with exactly the RULE text built from those f byte-identical. Schemas are those of the store files above; `second` is `Category` (plain) except in `tests.uq_pair` and `tests.uq_alias`, where it is `Alt` (unique, alias `Alt` and `alt` respectively). -The 13 rows of the spec are a floor; rows 14-24 extend it with orderings that a code-point, case-insensitive or +The 13 rows of the spec are a floor; rows 14-25 extend it with orderings that a code-point, case-insensitive or culture compare would flip. Rows, in file order: 1 batch-later-value-staged-first, 2 batch-surrogate-keys, 3 batch-interleaved-types, 4 batch-two-aliases, 5 held-then-landing, 6 held-in-the-least-group, 7 swap-off-a-held-value, 8 load-two-aliases, 9 load-surrogate-keys, 10 load-interleaved-types, 11 repull-held-pair, 12 load-repull-after, 13 commit-onto-a-loaded-holder, 14 batch-key-case (`B` before `a`), 15 batch-key-punctuation (`Z` before `_` before `a`), 16 batch-key-case-in-a-group, 17 batch-surrogate-groups (U+1F600 before U+E000, the reverse of code-point order), 18 batch-alias-case (alias `Sku` before `alt`), 19 load-alias-case, 20 load-key-case, 21 load-key-punctuation, 22 -load-surrogate-groups, 23 batch-holders-by-case (`a` and `A` holding one value: `A` before `a`), 24 load-holders-by-case. +load-surrogate-groups, 23 batch-holders-by-case (`a` and `A` holding one value: `A` before `a`), 24 load-holders-by-case, 25 batch-replaced-by-case (held `a`, then a commit of `A` on its value: `A` does not replace `a`). Rows 19-22 and 24 open a store holding the records of rows 18, 14, 15, 17 and 23, so a runtime with no batch commit still walks alias and cross-group key order. -A runtime performs every row its API can perform and asserts the count it walked: +A runtime performs every row its API can perform and asserts the count it walks. These are the counts a runtime must +assert, not a statement of which runtimes walk them today: -- C# and Rust: all 24. -- Python: 23, every row but 3 (`put_envelopes` takes one type). -- TypeScript: 12, rows 5, 8, 9, 10, 11, 12, 13, 19, 20, 21, 22 and 24 (no batch commit, so no row 1-4, 6, 7, 14-18 or 23; - `variants:idea:unique-index-runtimes.ts-batch-commit`). +- C# and Rust: all 25. +- Python: 24, every row but 3 (`put_envelopes` takes one type). +- TypeScript: 12, the rows that only open or pull a store: 5, 8, 9, 10, 11, 12, 13, 19, 20, 21, 22 and 24 (no batch commit, so no + row 1-4, 6, 7, 14-18, 23 or 25; `variants:idea:unique-index-runtimes.ts-batch-commit`). + +Not pinned: the schema-name tiebreak. Record keys are unique across a whole cache, so two types never hold the same key and +two groups can never tie on alias and key pair; the final `schema` comparison cannot decide a refusal. diff --git a/tests/vectors/unique-index/refusals.msgpack b/tests/vectors/unique-index/refusals.msgpack index bf2bd7ca0c5d165ed2060a4e9f57e587e4f8bfaf..d18c56e284854f09f5c854826ef256edd845fa25 100644 GIT binary patch delta 66 zcmV-I0KNaT7O@ut+yEJ|12GGe@COJOa%FIAVPj=vEn;~sV_|b;lai!waAj`5lehvQ Y43ef}Z*6U9bdi*yL6ZRo7n9Bk87rX}=>Px# delta 12 TcmdlezD11r4uix-W