R-AM: snapshot handler and dispatch backstop answer/log untyped faults
HandleSnapshotRequestV1Async only caught the three typed selection exceptions, unlike its siblings HandleShardLogRequestAsync/HandlePutAsync, which catch Exception and answer a CultNetErrorMessage. An untyped fault (e.g. a null Selection) escaped into the RUDP dispatch backstop, which swallowed it with no log - the same backstop that hid SM-6's ArgumentNullException regression for a whole batch. - HandleSnapshotRequestV1Async now catches Exception like its siblings and answers a CultNetErrorMessage. - RudpCultNetSchemaServer gets a Logger (ILogger/NullLogger, same pattern as Server/Client), and DispatchAsync's backstop always logs the fault it swallows, unwrapping DynamicInvoke's TargetInvocationException wrapper so the logged message is the handler's real exception, not the generic invocation-wrapper text. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
parent
375b6177ae
commit
77cd9649ec
2 changed files with 34 additions and 5 deletions
|
|
@ -263,6 +263,16 @@ namespace GameCult.Networking
|
|||
{
|
||||
peer.SendCultNet(CultNetErrorMessage.ForReferenceOutsideTarget(ex));
|
||||
}
|
||||
// R-AM: an untyped fault answers like HandleShardLogRequestAsync/HandlePutAsync's own
|
||||
// catch (Exception) - a CultNetErrorMessage on the wire, not silence. Before this, only
|
||||
// the three typed selection exceptions were caught here; anything else propagated up into
|
||||
// the dispatch backstop (CultNetRudpSchemaServer.cs), which swallowed it with no log and
|
||||
// hid SM-6's ArgumentNullException regression for a whole batch.
|
||||
catch (Exception ex)
|
||||
{
|
||||
_server.Logger.LogError($"CultNet snapshot v1 request failed: {ex.Message}");
|
||||
peer.SendCultNet(new CultNetErrorMessage { Error = ex.Message });
|
||||
}
|
||||
|
||||
return Task.CompletedTask;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue