From 735654f0778b00f182deeeb30e8e01a266c6a803 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Sun, 11 Oct 2026 17:52:25 +0200 Subject: [PATCH] cultmesh-rs: snapshot documents are applied by one method, and a 257-deep peer payload is refused pull_rudp_catalog_snapshot hands its documents to apply_raw_snapshot_documents (the network-free seam); the test feeds it a payload one level past the bound and checks nothing reaches the store. Co-Authored-By: Claude Sonnet 5.5 --- packages/cultmesh-rs/src/lib.rs | 63 +++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/packages/cultmesh-rs/src/lib.rs b/packages/cultmesh-rs/src/lib.rs index 1af0d906..d11774dd 100644 --- a/packages/cultmesh-rs/src/lib.rs +++ b/packages/cultmesh-rs/src/lib.rs @@ -727,6 +727,15 @@ impl CultMeshNode { let cultnet_rs::CultNetMessage::SnapshotResponseRaw { documents, .. } = response else { anyhow::bail!("expected cultnet.snapshot_response_raw.v0"); }; + self.apply_raw_snapshot_documents(documents) + } + + /// Admits a peer's snapshot documents into the cache, the network payloads included: the cache + /// refuses one nested past its bound and persists nothing from it. + fn apply_raw_snapshot_documents( + &mut self, + documents: Vec, + ) -> Result { let mut applied = 0usize; for document in documents { let Some(document_type) = @@ -1733,6 +1742,60 @@ mod tests { Ok(()) } + #[derive(serde::Serialize)] + struct Nest { + inner: Option>, + } + + // `levels` maps deep, written by the serializer the cache itself uses. + fn nest(levels: usize) -> Vec { + let mut value = Nest { inner: None }; + for _ in 1..levels { + value = Nest { inner: Some(Box::new(value)) }; + } + rmp_serde::to_vec_named(&value).unwrap() + } + + fn peer_document(key: &str, payload: Vec) -> cultnet_rs::CultNetRawDocumentRecord { + cultnet_rs::CultNetRawDocumentRecord { + schema_id: "cultmesh.test.note.v0".to_string(), + record_key: key.to_string(), + stored_at: "2026-07-03T00:00:00Z".to_string(), + payload_encoding: cultnet_rs::CultNetRawPayloadEncoding::Messagepack, + payload, + source_runtime_id: None, + source_agent_id: None, + source_role: None, + tags: None, + } + } + + #[test] + fn a_peer_payload_nested_past_the_bound_is_refused_and_nothing_is_persisted() -> Result<()> { + let temp = tempfile::tempdir()?; + let store_path = temp.path().join("cultmesh.cc"); + let mut node = CultMesh::create_node(&store_path, TestDocuments, Default::default())?; + + let limit = cultcache_rs::MAX_PAYLOAD_DEPTH; + assert_eq!(node.apply_raw_snapshot_documents(vec![peer_document("at", nest(limit))])?, 1); + node.flush()?; + let held = std::fs::read(&store_path)?; + + let error = node + .apply_raw_snapshot_documents(vec![peer_document("past", nest(limit + 1))]) + .unwrap_err(); + assert_eq!( + error.downcast_ref::(), + Some(&cultcache_rs::PayloadTooDeep { depth: limit + 1, limit }) + ); + node.flush()?; + assert_eq!(std::fs::read(&store_path)?, held); + let reloaded = CultMesh::create_node(&store_path, TestDocuments, Default::default())?; + let keys: Vec<_> = reloaded.cache().snapshot().into_iter().map(|entry| entry.key).collect(); + assert_eq!(keys, vec!["at".to_string()]); + Ok(()) + } + #[test] fn stream_catalog_negotiates_and_publishes_latest_shared_memory_frame() -> Result<()> { let mut catalog = CultMesh::create_stream_catalog();