GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

JudgeChecks (directory): drop the CreateDirectory the commit lease already makes; tests for a never-written non-home store and for a check-less batch beside a held lock

Browse source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-14 02:23:14 +02:00
commit 696a712088
2 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/GameCult.Caching.MessagePack/DirectoryMessagePackBackingStore.cs
View file

@ -272,7 +272,6 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
return base.JudgeChecks(keys, wait);
return Held(() =>
{
Directory.CreateDirectory(_manifestFile.DirectoryName!);
using var commitLease = AcquireCommitLease(wait, create: true);
if (commitLease == null)
return CultCommitOutcome.Contended;

37
tests/GameCult.Caching.Tests/ForeignRecordTests.cs
View file

@ -1488,6 +1488,43 @@ namespace GameCult.Caching.Tests
Assert.That(Fingerprint(home), Is.EqualTo(homeBefore));
}
// A non-home store the cache attached before anything was written to it has no directory and no lease yet: judging a check
// there creates what it locks, finds nothing, and writes no store.
[Test]
public void ANonHomeStoreNothingWasEverWrittenToJudgesAChecksOnlyCommit([Values] bool directory)
{
var home = PathOf("home.cc");
using (var seed = Open(home, DeckOnly, directory))
seed.Commit(batch => batch.Upsert(Deck, DeckOf("d"), D));
var other = PathOf("fresh" + Path.DirectorySeparatorChar + "other.cc");
using var cache = new CultCache(CultDocumentRegistry.ForTypes(new[] { Deck, Gizmo }));
cache.AddBackingStore(StoreAt(home, directory, readOnly: false), Deck);
cache.AddBackingStore(StoreAt(other, directory, readOnly: false), Gizmo);
Assert.That(cache.Commit(batch =>
{
batch.Upsert(Deck, DeckOf("d2"), new CultRecordKey("d2"));
batch.Remove(W);
}), Is.True);
Assert.That(Read(home).Records.Select(record => record.Key), Does.Contain("d2"));
Assert.That(File.Exists(other), Is.False, "judging a check writes no store");
}
// A batch with no check asks no other store anything: a lock another writer holds on a store the batch does not write does
// not stand in its way.
[Test]
public void ABatchWithoutChecksIsNotHeldUpByAnotherStoreLock()
{
var (cache, home, other) = TwoWritableStores(directory: false, otherListsWidget: false);
using var _ = cache;
using (new FileStream(other + ".lock", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
Assert.That(cache.TryCommit(batch => batch.Upsert(Deck, DeckOf("d2"), new CultRecordKey("d2"))), Is.EqualTo(CultCommitOutcome.Committed));
Assert.That(Read(home).Records.Select(record => record.Key), Does.Contain("d2"));
}
// A foreign record a refusal lists carries the version the refusal read, so a conditional commit over the stores that
// list it holds when nothing has changed since.
[Test]