From 5588e95fa23b4bcf398025aee972edd2c7c428d1 Mon Sep 17 00:00:00 2001
From: Meta Vens <rwvens@hotmail.com>
Date: Wed, 14 Oct 2026 20:26:51 +0200
Subject: [PATCH] cultmath: pin every shader constant to its C# twin
 (shader-third-constant-unpinned)

EveryShaderConstantEqualsItsCSharpTwin reflects each CULTMATH_* literal of the compiled HLSL
mirror and asserts it is bit-equal to the math constant of the same name, so CULTMATH_SNOISE_THIRD
(and every other constant) edited in one runtime fails.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---
 .../HlslSourceCompatibilityTests.cs           | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/packages/cultmath/tests/CultMath.Tests/HlslSourceCompatibilityTests.cs b/packages/cultmath/tests/CultMath.Tests/HlslSourceCompatibilityTests.cs
index 4ca598ad..f1ecb780 100644
--- a/packages/cultmath/tests/CultMath.Tests/HlslSourceCompatibilityTests.cs
+++ b/packages/cultmath/tests/CultMath.Tests/HlslSourceCompatibilityTests.cs
@@ -48,6 +48,42 @@ public sealed class HlslSourceCompatibilityTests
     // Mirror internals with no public C# math counterpart. Any other cultmath_* function must match one.
     private static readonly string[] MirrorOnly = { "cultmath_snoise_mod289", "cultmath_snoise_permute" };
 
+    // Shader constants with no C# twin of the same name (empty when every constant has one).
+    private static readonly string[] ConstantsWithoutTwin = Array.Empty<string>();
+
+    /// <summary>
+    /// Every static const of the compiled HLSL mirror (a public static literal CULTMATH_* field) is the
+    /// same float32, bit for bit, as the math constant of the same name without the prefix (private ones
+    /// included), so a pin edited in one runtime and not the other fails here whichever constant it is.
+    /// A constant with neither a twin nor a listing in ConstantsWithoutTwin fails too.
+    /// </summary>
+    [Fact]
+    public void EveryShaderConstantEqualsItsCSharpTwin()
+    {
+        var (assembly, errors) = CompileShaderMirror();
+        Assert.True(assembly is not null, string.Join(Environment.NewLine, errors));
+        var shader = assembly!.GetType("CultMathHlsl.HlslShader")!;
+        var constants = shader.GetFields(BindingFlags.Public | BindingFlags.Static)
+            .Where(f => f.IsLiteral && f.Name.StartsWith("CULTMATH_", StringComparison.Ordinal))
+            .ToArray();
+        Assert.True(constants.Length >= 10, $"only {constants.Length} shader constants were found by reflection");
+        foreach (var constant in constants)
+        {
+            var name = constant.Name["CULTMATH_".Length..];
+            var twin = typeof(math).GetField(name, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static);
+            if (twin is null)
+            {
+                Assert.True(ConstantsWithoutTwin.Contains(constant.Name), $"{constant.Name} has no math.{name} and is not listed in ConstantsWithoutTwin");
+                continue;
+            }
+
+            var shaderValue = (float)constant.GetRawConstantValue()!;
+            var mathValue = (float)twin.GetValue(null)!;
+            Assert.True(BitConverter.SingleToInt32Bits(shaderValue) == BitConverter.SingleToInt32Bits(mathValue),
+                $"{constant.Name} is {shaderValue:R} in the shader and math.{name} is {mathValue:R}");
+        }
+    }
+
     private static readonly float[] Specials = { 0.0f, -0.0f, 1.0f, -1.0f, 0.5f, -2.75f, 3.0f, 1.0e-7f, 1.0e4f, -1.0e4f, 1.0e7f, float.NaN };
 
     /// <summary>