GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

A repair request is not a keyframe request

Browse source 
The builder forced requested_keyframe whenever chunk keys were missing.
A producer answers each new keyframe request with an IDR, so every
repair request would have cost a keyframe — the thing a repair request
exists to avoid. The old C++ receiver sent repairs with the flag off;
this builder had never been driven by a real receiver. A whole missing
frame still implies one, since the repair cache holds chunks.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-10 21:35:04 +02:00
commit 4160ab560b
1 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
packages/cultnet-rs/src/media_stream_wire.rs
View file

@ -449,8 +449,9 @@ pub fn validate_feedback_record(record: &GameCultMediaReceiverFeedbackRecord) ->
/// What a receiver has to say about a stream. The record it builds is the
/// contract's; this normalises it so both ends agree on its shape: damage
/// lists sorted and unique, chunk keys well-formed, and a keyframe requested
/// whenever something is missing, since a producer cannot repair a reference
/// the receiver never had.
/// whenever a whole frame is missing, since a producer's repair cache holds
/// chunks, not references. Missing chunks alone are a repair request, which
/// exists precisely so that a keyframe is not needed.
#[derive(Clone, Debug)]
pub struct ReceiverFeedbackOptions<'a> {
pub stream_id: &'a str,
@ -477,9 +478,7 @@ pub fn build_receiver_feedback(
let mut late_frame_ids = options.late_frame_ids;
late_frame_ids.sort_unstable();
late_frame_ids.dedup();
let requested_keyframe = options.requested_keyframe
|| !missing_frame_ids.is_empty()
|| !missing_video_chunk_keys.is_empty();
let requested_keyframe = options.requested_keyframe || !missing_frame_ids.is_empty();
let record = GameCultMediaReceiverFeedbackRecord {
stream_id: options.stream_id.to_string(),
@ -535,7 +534,19 @@ mod receiver_feedback_tests {
assert_eq!(feedback.missing_frame_ids, vec![42, 43]);
assert_eq!(feedback.missing_video_chunk_keys, vec!["42:1", "43:2"]);
assert_eq!(feedback.late_frame_ids, vec![38, 39]);
assert!(feedback.requested_keyframe, "missing chunks imply a lost reference");
assert!(feedback.requested_keyframe, "a whole missing frame is a lost reference");
Ok(())
}
/// A producer answers a keyframe request with an IDR. A repair request is
/// the cheaper alternative and must not carry one by accident.
#[test]
fn a_repair_request_does_not_ask_for_a_keyframe() -> Result<()> {
let feedback = build_receiver_feedback(ReceiverFeedbackOptions {
missing_video_chunk_keys: vec![video_chunk_feedback_key(42, 1)],
..options()
})?;
assert!(!feedback.requested_keyframe);
Ok(())
}