GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

cultcache-ts: previewPayload reads through decodeBoundedPayload (the inspector's one walk site); the map32 and array32 counts are pinned above 65535

Browse source 
The wide-count test announced map32 as 32770 pairs, which fits in 16 bits, so a
count read as its low 16 bits survived. map32 now announces 65537 pairs and
array32 65540 children; both low halves close the container early.

Builds: yes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-12 01:50:05 +02:00
commit 3b2af2b232
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/cultcache-ts/src/cult-cache-inspector.ts
View file

@ -295,8 +295,7 @@ function decodeBoundedPayload(payload: Uint8Array): unknown {
function previewPayload(payload: Uint8Array): Pick<InspectedRecord, "payloadPreview" | "payloadDecodeError"> {
try {
checkPayloadDepth(payload);
return { payloadPreview: toJsonSafe(decode(payload)) };
return { payloadPreview: toJsonSafe(decodeBoundedPayload(payload)) };
} catch (error) {
return {
payloadPreview: {

9
packages/cultcache-ts/test/payload-depth.test.ts
View file

@ -222,8 +222,13 @@ test("a 32-bit length or count is read whole: the walk skips a 65539-byte scalar
assert.doesNotThrow(() => checkPayloadDepth(cat(bytes(0x92), scalar, arrays(L - 1))), `${name} of 65539 bytes then a chain at the limit`);
refused(cat(bytes(0x92), scalar, arrays(L)), `${name} of 65539 bytes then a chain past it`);
}
const nils = repeat(bytes(0xc0), 65540);
for (const [name, header] of [["array32", cat(bytes(0xdd), be32(65540))], ["map32", cat(bytes(0xdf), be32(32770))]] as const) {
// Both counts exceed 65535 and their low sixteen bits are small (4 children; 1 pair), so a count cut to 16 bits closes the container early.
const wide: [string, Uint8Array, number][] = [
["array32", cat(bytes(0xdd), be32(65540)), 65540],
["map32", cat(bytes(0xdf), be32(65537)), 2 * 65537],
];
for (const [name, header, children] of wide) {
const nils = repeat(bytes(0xc0), children);
refused(cat(bytes(0x92), header, nils, arrays(L)), `${name} announcing more than 65535: the sibling chain past the limit`);
assert.doesNotThrow(() => checkPayloadDepth(cat(bytes(0x92), header, nils, arrays(L - 1))), `${name}: the sibling chain at the limit`);
}