GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions 4

cultmesh-ts/content tests: release the FIFO's blocked opens without the thread pool

Browse source 
The finally block hashed (a pool job) before releasing, so under a reverted
non-blocking open it deadlocked behind the full pool; the path is now kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-19 18:31:11 +02:00
commit 3479f7426a
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/cultmesh-ts/test/content.test.ts
View file

@ -342,11 +342,13 @@ test("a store that overwrites its buffer on any microtask hop never gets other b
test("a FIFO named by a hash is refused as not a regular file at once and holds no thread: other chunks are still served", { skip: process.platform === "win32" }, async () => {
const root = await mkdtemp(join(tmpdir(), "cm-content-"));
let fifoPath: string | undefined;
try {
const chunk = await packed("hello chunk");
await writeFile(join(root, chunk.chunkHash), chunk.payload);
const fifoHash = await sha256Hex(new Uint8Array([9]));
execFileSync("mkfifo", [join(root, fifoHash)]);
fifoPath = join(root, fifoHash);
execFileSync("mkfifo", [fifoPath]);
const store = createDirectoryChunkStore(root);
const within = async <T,>(work: Promise<T>): Promise<T> => {
let timer: NodeJS.Timeout | undefined;
@ -360,8 +362,9 @@ test("a FIFO named by a hash is refused as not a regular file at once and holds
assert.equal((await within(createContentChunkHandler(store)({ method: "GET", url: `/?chunkHash=${fifoHash}` }))).status, 500);
} finally {
// A reverted non-blocking open leaves pool threads waiting for a writer, which would keep the process alive past the failure.
// Opening the FIFO read-write (synchronously: the pool is full) releases them, so the revert fails the test in seconds.
try { closeSync(openSync(join(root, await sha256Hex(new Uint8Array([9]))), fsConstants.O_RDWR | fsConstants.O_NONBLOCK)); } catch { /* already gone */ }
// Opening the FIFO read-write releases them, so the revert fails the test in seconds. It is synchronous and needs no
// hash: both hashing and async fs calls queue behind the full pool.
if (fifoPath) try { closeSync(openSync(fifoPath, fsConstants.O_RDWR | fsConstants.O_NONBLOCK)); } catch { /* already gone */ }
await rm(root, { recursive: true, force: true });
}
});