GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Tests: the directory store names its refused manifest and keeps the entry that publishes a compatible id

Browse source 
The two paths the previous batch left unpinned. Replication routing comments in cultnet-py and cultnet-ts say what the payload-based
and binding-based resolution is and is not.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-30 07:45:31 +02:00
commit 2d2fad1f45
3 changed files with 43 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/cultnet-py/src/cultnet_py/replication.py
View file

@ -167,6 +167,7 @@ def resolve_document_for_raw_record(
return resolve_document_and_schema_id_for_raw_record(documents_by_schema_id, schema_id, record)[0]
# routes a replicated raw record to a local binding; the store always persists the local schema id; this is not store-reader recovery.
def resolve_document_and_schema_id_for_raw_record(
documents_by_schema_id: dict[str, DocumentDefinition[Any]],
schema_id: str,

1
packages/cultnet-ts/src/replication.ts
View file

@ -300,6 +300,7 @@ export class CultNetDocumentRegistry {
return binding;
}
// routes a replicated raw record to a local binding; the store always persists the local schema id; this is not store-reader recovery.
#resolveRawDocumentBinding(document: CultNetRawDocumentRecord): CultNetDocumentBinding {
const exact = this.getBySchemaId(document.schemaId);
if (exact) {

41
tests/GameCult.Caching.Tests/StoreReadabilityTests.cs
View file

@ -114,6 +114,47 @@ namespace GameCult.Caching.Tests
Assert.That(File.ReadAllBytes(path), Is.EqualTo(bytes), "a file this runtime cannot read was rewritten");
}
private string DirectoryStore(string name)
{
var path = Path.Combine(_directory, name);
using var cache = CultCacheMessagePack.Create(path, new CultCacheOpenOptions { Registry = Registry, UseDirectoryStore = true });
cache.Commit(batch => batch.Upsert(typeof(IdDeck), new IdDeck { Name = "d" }, new CultRecordKey("d")));
return path;
}
// The directory store's refusal names the manifest it refused, as the single-file store names its file.
[Test]
public void AnUnreadableDirectoryManifestIsRefusedNamingIt()
{
var path = DirectoryStore("manifest.cc");
File.WriteAllBytes(path, new byte[] { 0x01 });
Assert.That(
() => CultCacheMessagePack.Create(path, new CultCacheOpenOptions { Registry = Registry, UseDirectoryStore = true }),
Throws.TypeOf<CultStoreUnreadableException>().With.Property(nameof(CultStoreUnreadableException.Path)).EqualTo(path));
}
// A record kept under an id its catalog entry lists only as a compatible id keeps that entry through a rewrite: the manifest
// the rewrite leaves is one this runtime reads.
[Test]
public void ADirectoryRewriteKeepsTheCatalogEntryThatPublishesAKeptRecordAsACompatibleId()
{
var path = DirectoryStore("compatible.cc");
var manifest = CultDocumentMessagePackSerialization.DeserializeSnapshot(File.ReadAllBytes(path));
var entry = manifest.SchemaCatalog.Single();
manifest.Records.Single().SchemaId = "vectors.old.id";
entry.SchemaId = "vectors.old.next";
entry.CompatibleSchemaIds = new[] { "vectors.old.id" };
File.WriteAllBytes(path, CultDocumentMessagePackSerialization.SerializeSnapshot(manifest));
using (var cache = CultCacheMessagePack.Create(path, new CultCacheOpenOptions { Registry = Registry, UseDirectoryStore = true }))
cache.Commit(batch => batch.Upsert(typeof(IdDeck), new IdDeck { Name = "e" }, new CultRecordKey("e")));
var rewritten = CultDocumentMessagePackSerialization.DeserializeSnapshot(File.ReadAllBytes(path));
Assert.That(rewritten.SchemaCatalog.Select(catalogEntry => catalogEntry.SchemaId), Does.Contain("vectors.old.next"));
Assert.That(rewritten.Records.Select(record => record.SchemaId), Does.Contain("vectors.old.id"));
}
// A commit that lands onto the file as it is keeps the header the file carries: a store already v3 stays v3.
[TestCase("../v3-base.msgpack", "cultcache.store.v3")]
[TestCase("compatible-id-only-v3.bin", "cultcache.store.v3")]