GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Removing a foreign record is refused typed, not reported as done

Browse source 
Remove and a committed batch removal of a key the cache does not hold ask every
store whether it carries a foreign record there (RefuseUndeclared); one that
does refuses with the typed schema conflict instead of Remove returning false
and Commit returning Committed over a record the store still carries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-03 13:11:24 +02:00
commit 28c9a03388
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/GameCult.Caching/CultCache.cs
View file

@ -2352,11 +2352,15 @@ namespace GameCult.Caching
return key;
}));
// Refused with CultSchemaConflictException when the key holds a record stored under an id no registered type declares.
// Refused with CultSchemaConflictException when the key holds a record stored under an id no registered type declares,
// read-only or foreign. False when the cache holds nothing there and no store carries a foreign record there.
public bool Remove(CultRecordKey key) => Held(() =>
{
if (!_entries.TryGetValue(key.Value, out var existing))
{
RefuseRemovalOfForeign(key.Value);
return false;
}
Admit(Array.Empty<CultStoredDocument>(), new[] { existing }, null, (home, _) =>
{
home?.Delete(existing);
@ -2627,6 +2631,8 @@ namespace GameCult.Caching
: op.Variant != null ? StampVariant(op.Key, DescriptorOfBase(op.Key, op.Variant.BaseKey, batch), op.Variant)
: StampFlatten(op.Key))
.ToArray();
foreach (var op in batch.Operations.Values.Where(op => op.IsRemoval && !_entries.ContainsKey(op.Key.Value)))
RefuseRemovalOfForeign(op.Key.Value);
var deletes = batch.Operations.Values
.Where(op => op.IsRemoval && _entries.ContainsKey(op.Key.Value))
.Select(op => _entries[op.Key.Value])
@ -2650,6 +2656,14 @@ namespace GameCult.Caching
});
}
// A removal of a key the cache does not hold removes nothing, so no store sees it; but a store that carries a foreign record
// at the key refuses it, as it refuses every write of that record, rather than let the caller believe it was removed.
private void RefuseRemovalOfForeign(string key)
{
foreach (var (store, _) in _stores)
store.RefuseUndeclared(key);
}
// Every add and remove passes here: single writes, committed batches, and loads (source set).
// Nothing lands unless all of it is admissible; land is the durable step between validation and memory.
private CultCommitOutcome Admit(