GameCult/CultLib
Watch
9
0
Fork
You've already forked CultLib
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Apply the same assertRejectsAndDisposes guard to the new provider test

Browse source 
The "dispose() evicts a connection still mid-handshake" test (previous
commit) used a bare assert.rejects(connector.connect(...)) to force the
handshake-rejection path it needs, which is exactly the pattern that hung
realtime-quic-consumer.test.ts under M1: found re-running M1 against the
full workspace after the previous fix — it hung again, this time in
realtime-quic-provider.test.ts, at this new test, for the same reason.
Ported the same assertRejectsAndDisposes() helper into this file rather
than importing it across test files (each file already keeps its own
small helpers).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-23 17:29:27 +02:00
commit 20ffef7cc6
1 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

24
packages/cultmesh-ts/test/realtime-quic-provider.test.ts
View file

@ -31,6 +31,28 @@ import { nativeBridgeAvailable } from "./support/native-bridge";
// levels up.
const FIXTURE_P12 = join(__dirname, "..", "..", "test", "fixtures", "quic-test.p12");
/**
* `assert.rejects`, but safe against a mutant or a real regression that
* makes the promise resolve instead: a transport that unexpectedly connects
* is disposed before the assertion fails, so a broken certificate check
* cannot hang this file the way M1 did before realtime-quic-consumer.test.ts
* gained this same helper.
*/
async function assertRejectsAndDisposes(
promise: Promise<{ dispose(): void }>,
match?: RegExp,
): Promise<void> {
let resolved: { dispose(): void } | undefined;
try {
resolved = await promise;
} catch (error) {
if (match) assert.match(error instanceof Error ? error.message : String(error), match);
return;
}
resolved.dispose();
assert.fail("expected the promise to reject, but it resolved (the resolved value has been disposed)");
}
function testFrame(overrides: Partial<CultMeshRealtimeFrame> = {}): CultMeshRealtimeFrame {
return {
channelId: "aetheria.entities",
@ -387,7 +409,7 @@ test(
generation: "gen-1",
};
const connector = new CultMeshQuicRealtimeConnector();
await assert.rejects(connector.connect(candidate, target), /certificate|rejected/i);
await assertRejectsAndDisposes(connector.connect(candidate, target), /certificate|rejected/i);
// The provider's own accept flow is asynchronous (attachPeer awaits a
// runtime reference before it can even see the rejection); give it a