C#: a record no registered type claims is carried untouched, and a write over it is refused
C2a F2, operator: "CultCache never destroys or relabels a record it doesn't understand; keeps it byte-for-byte, refuses writes that would overwrite it." - The registry's claim decision (Claimant) is split out of resolution. It never decodes or compares shapes, so a store classifies a record from its header. The last branch, "No local CultCache schema matches", now means foreign instead of a refused load. - Both store kinds keep a foreign record out of the cache and list it in CacheBackingStore.ForeignRecords (key, schema id, catalog name, storedAt). - Single-file store: a whole-view write lays back every foreign record the file holds now, with its catalog entry, and keeps a marked header while it carries one (it cannot see their ids). A staged write, a commit (onto the file or whole view) and a whole view over a key the file holds as foreign refuse with CultSchemaConflictException naming the key and id. A merge judgement never decodes a foreign record, and one that replaced a held record takes it away. - Directory store: a foreign record's page is never read; a generation that would replace or remove one refuses before any page is written. - Contracts: hard rejection no longer lists "no compatible local schema candidate"; the persistence format says what a foreign record is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
92d9e13868
commit
05221dae74
7 changed files with 535 additions and 33 deletions
|
|
@ -63,10 +63,12 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
|
||||
var reports = new List<CultSchemaMigrationReport>();
|
||||
var loaded = new Dictionary<string, CultStoredDocument>(StringComparer.Ordinal);
|
||||
var foreign = new List<CultForeignRecord>();
|
||||
for (var attempt = 1; ; attempt++)
|
||||
{
|
||||
loaded.Clear();
|
||||
reports.Clear();
|
||||
foreign.Clear();
|
||||
// Only pages named by the manifest read under the lease are loaded; orphaned pages are never loaded. With no
|
||||
// lock to lease (none created yet, or a store copied without it) a writer may commit mid-load, so an unleased
|
||||
// load stands only if its manifest is still current; if the manifest moved it reloads, under the lease the
|
||||
|
|
@ -83,7 +85,8 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
manifest.Records.OrderBy(record => record.Key, StringComparer.Ordinal).ToArray(),
|
||||
manifest.SchemaCatalog,
|
||||
loaded,
|
||||
reports);
|
||||
reports,
|
||||
foreign);
|
||||
if (lease != null || !ManifestMoved(manifestBytes))
|
||||
{
|
||||
Trace($"indexed-pages loaded={loaded.Count}");
|
||||
|
|
@ -129,6 +132,7 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
_hydratedKeys.Add(key);
|
||||
|
||||
SetLastSchemaMigrationReports(reports);
|
||||
SetForeignRecords(foreign);
|
||||
IsDirty = !_dirtyKeys.IsEmpty || !_deletedKeys.IsEmpty;
|
||||
Trace("publish");
|
||||
}
|
||||
|
|
@ -147,6 +151,7 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
RefuseVariant(entry);
|
||||
Held(() =>
|
||||
{
|
||||
RefuseOverwrite(entry.Key.Value);
|
||||
Entries[entry.Key.Value] = entry;
|
||||
_dirtyKeys[entry.Key.Value] = true;
|
||||
_deletedKeys.TryRemove(entry.Key.Value, out _);
|
||||
|
|
@ -239,6 +244,14 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
{
|
||||
Directory.CreateDirectory(_recordDirectory.FullName);
|
||||
var currentIndex = currentManifest.Records.ToDictionary(record => record.Key, record => record, StringComparer.Ordinal);
|
||||
// The manifest's other records stay as they are, foreign ones included; a write that would replace or remove a foreign
|
||||
// record is refused before any page is written.
|
||||
foreach (var key in _deletedKeys.Keys.Concat(_dirtyKeys.Keys))
|
||||
{
|
||||
if (currentIndex.TryGetValue(key, out var held) && Foreign(held, currentManifest.SchemaCatalog) is { } carried)
|
||||
throw Overwrites(carried);
|
||||
}
|
||||
|
||||
foreach (var key in _deletedKeys.Keys)
|
||||
currentIndex.Remove(key);
|
||||
foreach (var key in _dirtyKeys.Keys)
|
||||
|
|
@ -310,8 +323,20 @@ public sealed class DirectoryMessagePackBackingStore : CacheBackingStore
|
|||
CultPersistedRecord[] records,
|
||||
IReadOnlyCollection<CultSchemaCatalogEntry> catalogEntries,
|
||||
Dictionary<string, CultStoredDocument> loaded,
|
||||
List<CultSchemaMigrationReport> reports)
|
||||
List<CultSchemaMigrationReport> reports,
|
||||
List<CultForeignRecord> foreign)
|
||||
{
|
||||
// A record no registered type claims stays as the manifest names it: its page is never read, and a commit keeps it.
|
||||
var claimed = new List<CultPersistedRecord>(records.Length);
|
||||
foreach (var metadata in records)
|
||||
{
|
||||
if (Foreign(metadata, catalogEntries) is { } carried)
|
||||
foreign.Add(carried);
|
||||
else
|
||||
claimed.Add(metadata);
|
||||
}
|
||||
|
||||
records = claimed.ToArray();
|
||||
var tracePages = string.Equals(
|
||||
Environment.GetEnvironmentVariable("CULTCACHE_TRACE_STARTUP_PHASES"),
|
||||
"1",
|
||||
|
|
|
|||
Loading…
Reference in a new issue