CultLib/tests/GameCult.Caching.Tests/ConditionalCommitTests.cs

977 lines
44 KiB
C#
Raw Normal View History

#nullable enable
using System;
using System.Collections.Concurrent;
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using GameCult.Caching;
using GameCult.Caching.MessagePack;
using MessagePack;
using NUnit.Framework;
using R3;
namespace GameCult.Caching.Tests
{
public class ConditionalCommitTests
{
private static readonly CultRecordKey Key = new("counter");
private string _directory = string.Empty;
[SetUp]
public void CreateDirectory()
{
_directory = Path.Combine(Path.GetTempPath(), $"cultlib-conditional-{Guid.NewGuid():N}");
Directory.CreateDirectory(_directory);
}
[TearDown]
public void DeleteDirectory()
{
if (Directory.Exists(_directory))
Directory.Delete(_directory, recursive: true);
}
[Test]
public void StaleExpectFailsWithNothingChanged() => StaleExpect(SingleFile(PathOf("store.cc")));
[Test]
public void ExpectNullIsCreateOnce() => CreateOnce(SingleFile(PathOf("store.cc")));
[Test]
public void PerEntryCommitSurvivesUnrelatedWrite() => UnrelatedWrite(SingleFile(PathOf("store.cc")));
[Test]
public void ExpectUnchangedFailsOnUnrelatedInsert() => UnrelatedInsert(SingleFile(PathOf("store.cc")));
[Test]
public void DirectoryStoreHonorsConditions()
{
StaleExpect(DirectoryStore(PathOf("stale.cc")));
CreateOnce(DirectoryStore(PathOf("create.cc")));
UnrelatedWrite(DirectoryStore(PathOf("unrelated.cc")));
UnrelatedInsert(DirectoryStore(PathOf("insert.cc")));
}
// The lock is a FileShare.None handle, which excludes another handle in this process exactly as it does one in
// another process, so two store instances on two threads prove the property without a process boundary.
[Test]
public void TwoWritersRacingExactlyOneWins()
{
const int n = 100;
var store = SingleFile(PathOf("race.cc"));
Create(store, 0);
using var a = store.Open();
using var b = store.Open();
Assert.That(Increment(a), Is.True);
Assert.That(Increment(b), Is.False, "b observed before a committed and still won");
b.PullAllBackingStoresAsync();
Assert.That(Increment(b), Is.True);
Assert.That(Increment(a), Is.False, "a committed over b's newer record from its stale view");
var racers = new[] { a, b }.Select(cache => Task.Run(() =>
{
var wins = 0;
var mismatches = 0;
for (var attempt = 0; wins < n && attempt < 50 * n; attempt++)
{
cache.PullAllBackingStoresAsync();
if (Increment(cache))
wins++;
else
mismatches++;
}
return (Wins: wins, Mismatches: mismatches);
})).ToArray();
Assert.That(Task.WaitAll(racers, TimeSpan.FromMinutes(2)), Is.True, "the racers did not finish");
Assert.That(racers.Select(racer => racer.Result.Wins), Is.All.EqualTo(n));
Assert.That(racers.Sum(racer => racer.Result.Mismatches), Is.GreaterThan(0), "the writers never actually raced");
using var reader = store.Open();
Assert.That(reader.Get<Counter>(Key)!.Value, Is.EqualTo(2 + 2 * n));
}
[Test]
public void TryCommitReportsContended()
{
var path = PathOf("contended.cc");
var store = SingleFile(path);
Create(store, 0);
using var cache = store.Open();
var before = File.ReadAllBytes(path);
Task<bool> waiting;
using (new FileStream(path + ".lock", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
{
Assert.That(cache.TryCommit(batch => batch.Upsert(new Counter { Name = "x" }, new CultRecordHandle<Counter>(new CultRecordKey("x")))),
Is.EqualTo(CultCommitOutcome.Contended));
Assert.That(File.ReadAllBytes(path), Is.EqualTo(before));
Assert.That(cache.Get(new CultRecordKey("x")), Is.Null);
waiting = Task.Run(() => cache.Commit(batch => batch.Upsert(new Counter { Name = "y" }, new CultRecordHandle<Counter>(new CultRecordKey("y")))));
Assert.That(waiting.Wait(200), Is.False, "Commit did not wait for the held lock");
}
Assert.That(waiting.Wait(TimeSpan.FromSeconds(10)) && waiting.Result, Is.True);
Assert.That(cache.Get(new CultRecordKey("y")), Is.Not.Null);
}
[Test]
public void TryCommitIsNotContendedByAConcurrentReader()
{
var path = PathOf("reader.cc");
var store = SingleFile(path);
Create(store, 0);
using var cache = store.Open();
var handle = new CultRecordHandle<Counter>(new CultRecordKey("read-under"));
var running = true;
var reads = 0;
using var started = new ManualResetEventSlim();
var reading = Task.Run(() =>
{
started.Set();
while (Volatile.Read(ref running))
{
_ = cache.AllStoredDocuments.Count();
Interlocked.Increment(ref reads);
}
});
try
{
Assert.That(started.Wait(TimeSpan.FromSeconds(10)), Is.True);
for (var i = 0; i < 200; i++)
Assert.That(cache.TryCommit(batch => batch.Upsert(new Counter { Name = "read-under", Value = i }, handle)),
Is.EqualTo(CultCommitOutcome.Committed), $"attempt {i} lost to a reader, not a writer");
}
finally
{
Volatile.Write(ref running, false);
Assert.That(reading.Wait(TimeSpan.FromSeconds(10)), Is.True);
}
Assert.That(reads, Is.GreaterThan(0));
using (new FileStream(path + ".lock", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
Assert.That(cache.TryCommit(batch => batch.Upsert(new Counter { Name = "read-under" }, handle)),
Is.EqualTo(CultCommitOutcome.Contended));
}
[Test]
public void PushAllWaitsForHeldStoreLock()
{
var path = PathOf("push-wait.cc");
using var cache = SingleFile(path).Open();
cache.UpsertAsync(new Counter { Name = "pushed" }, new CultRecordHandle<Counter>(Key));
Task flush;
using (new FileStream(path + ".lock", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
{
flush = Task.Run(() => cache.FlushAllBackingStores());
Assert.That(flush.Wait(150), Is.False, "PushAll did not wait for the held store lock");
Assert.That(File.Exists(path), Is.False);
}
Assert.That(flush.Wait(TimeSpan.FromSeconds(10)), Is.True);
using var reader = SingleFile(path).Open();
Assert.That(reader.Get(Key), Is.Not.Null);
}
[Test]
public void CommitWaitsForHeldStoreLock()
{
var path = PathOf("commit-wait.cc");
using var cache = SingleFile(path).Open();
Task<bool> commit;
using (new FileStream(path + ".lock", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None))
{
commit = Task.Run(() => CreateCommit(cache, 7));
Assert.That(commit.Wait(150), Is.False, "Commit did not wait for the held store lock");
Assert.That(File.Exists(path), Is.False);
}
Assert.That(commit.Wait(TimeSpan.FromSeconds(10)), Is.True);
Assert.That(commit.Result, Is.True);
using var reader = SingleFile(path).Open();
Assert.That(reader.Get<Counter>(Key)!.Value, Is.EqualTo(7));
}
[Test]
public void PlainFlushNeverInterleaves()
{
var path = PathOf("interleave.cc");
var store = SingleFile(path);
Create(store, 0);
using var flusher = store.Open();
using var committer = store.Open();
var running = true;
var reads = 0;
var flushing = Task.Run(() =>
{
for (var i = 0; i < 50; i++)
{
flusher.UpsertAsync(new Counter { Name = "flushed", Value = i }, new CultRecordHandle<Counter>(new CultRecordKey("flushed")));
flusher.FlushAllBackingStores();
}
});
var committing = Task.Run(() =>
{
for (var i = 0; i < 50; i++)
{
var key = new CultRecordKey($"committed:{i}");
committer.Commit(batch =>
{
batch.Expect(key, null);
batch.Upsert(new Counter { Name = key.Value, Value = i }, new CultRecordHandle<Counter>(key));
});
}
});
var reading = Task.Run(() =>
{
while (Volatile.Read(ref running))
{
byte[] bytes;
try
{
using var stream = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete);
using var buffer = new MemoryStream();
stream.CopyTo(buffer);
bytes = buffer.ToArray();
}
catch (IOException)
{
// An open that loses to a replace in flight (moved away, or held by the replace) is not a read.
continue;
}
CultDocumentMessagePackSerialization.DeserializeSnapshot(bytes);
reads++;
}
});
Assert.That(Task.WaitAll(new[] { flushing, committing }, TimeSpan.FromMinutes(2)), Is.True, "the writers did not finish");
Volatile.Write(ref running, false);
Assert.That(() => reading.Wait(TimeSpan.FromSeconds(10)), Throws.Nothing);
Assert.That(reads, Is.GreaterThan(0));
}
[Test]
public void StoredAtIsStrictlyIncreasingPerKey()
{
using var cache = SingleFile(PathOf("stamps.cc")).Open();
var stamps = new string[1000];
for (var i = 0; i < stamps.Length; i++)
{
cache.UpsertAsync(new Counter { Name = "stamped", Value = i }, new CultRecordHandle<Counter>(Key));
stamps[i] = cache.AllStoredDocuments.Single().StoredAt;
}
Assert.That(stamps.Distinct().Count(), Is.EqualTo(stamps.Length));
var instants = stamps.Select(stamp => DateTimeOffset.Parse(stamp, null, System.Globalization.DateTimeStyles.RoundtripKind)).ToArray();
Assert.That(instants.Zip(instants.Skip(1), (earlier, later) => later > earlier), Is.All.True);
}
[Test]
public void DirtyStoreRefusesConditionalCommit()
{
using var cache = SingleFile(PathOf("dirty.cc")).Open();
cache.UpsertAsync(new Counter { Name = "staged" });
Assert.That(() => cache.Commit(batch =>
{
batch.Expect(Key, null);
batch.Upsert(new Counter { Name = "counter" }, new CultRecordHandle<Counter>(Key));
}), Throws.InvalidOperationException.With.Message.Contains("flush"));
Assert.That(cache.Get(Key), Is.Null);
}
[Test]
public void CrossStoreConditionalBatchThrowsBeforeAnyStore()
{
using var cache = new CultCache(Registry);
cache.AddBackingStore(new SingleFileMessagePackBackingStore(PathOf("counters.cc")), typeof(Counter));
cache.AddBackingStore(new SingleFileMessagePackBackingStore(PathOf("tallies.cc")), typeof(Tally));
Assert.That(() => cache.Commit(batch =>
{
batch.Expect(Key, null);
batch.Upsert(new Counter { Name = "counter" }, new CultRecordHandle<Counter>(Key));
batch.Upsert(new Tally { Name = "tally" }, new CultRecordHandle<Tally>(new CultRecordKey("tally")));
}), Throws.InvalidOperationException.With.Message.Contains("one home store"));
Assert.That(System.IO.Directory.GetFiles(_directory), Is.Empty, "a store file or lock file was touched");
}
// Cache A pulls and upserts on two threads while cache B commits to the same directory store; the pull's load
// callback and the upsert's push must take the cache gate and the store lock in one order. A is not disposed on
// failure because a deadlocked gate would hang the test thread too.
[Test]
public void PullAndUpsertOnDirectoryStoreDoNotDeadlock()
{
var store = DirectoryStore(PathOf("deadlock.cc"));
var a = store.Open();
using var b = store.Open();
var pulling = Task.Run(() =>
{
for (var i = 0; i < 300; i++)
a.PullAllBackingStoresAsync();
});
var upserting = Task.Run(() =>
{
for (var i = 0; i < 3000; i++)
a.UpsertAsync(new Counter { Name = $"a:{i}" }, new CultRecordHandle<Counter>(new CultRecordKey($"a:{i}")));
});
var writing = Task.Run(() =>
{
for (var i = 0; i < 150; i++)
{
b.UpsertAsync(new Counter { Name = $"b:{i}" }, new CultRecordHandle<Counter>(new CultRecordKey($"b:{i}")));
b.FlushAllBackingStores();
}
});
Assert.That(Task.WaitAll(new[] { pulling, upserting, writing }, TimeSpan.FromSeconds(60)), Is.True, "pull and upsert deadlocked");
a.Dispose();
}
[Test]
public void RepullNeverErasesAStagedWrite()
{
var path = PathOf("repull.cc");
Create(SingleFile(path), 0);
var store = new PausingStore(path);
using var cache = new CultCache(Registry);
cache.AddBackingStore(store);
var staged = new CultRecordKey("staged");
using (var release = new ManualResetEventSlim())
{
store.Pause = release;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
try
{
var pulling = Task.Run(() => cache.PullAllBackingStoresAsync());
Assert.That(store.Entered.Wait(TimeSpan.FromSeconds(10)), Is.True, "the pull never read the file");
using var started = new ManualResetEventSlim();
var writing = Task.Run(() =>
{
started.Set();
return cache.UpsertAsync(new Counter { Name = "staged" }, new CultRecordHandle<Counter>(staged));
});
Assert.That(started.Wait(TimeSpan.FromSeconds(10)), Is.True, "the writer never started");
writing.Wait(200);
Assert.That(store.PushedWhilePaused, Is.False, "a write reached the store while the pull held the gate");
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
store.Pause = null;
release.Set();
Assert.That(Task.WaitAll(new Task[] { pulling, writing }, TimeSpan.FromSeconds(10)), Is.True);
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
}
finally
{
store.Pause = null;
release.Set();
}
}
Assert.That(cache.Get(staged), Is.Not.Null, "the re-pull erased a staged write from the cache");
cache.FlushAllBackingStores();
using var reader = SingleFile(path).Open();
Assert.That(reader.Get(staged), Is.Not.Null, "the flush after the re-pull lost the staged write");
}
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
// The pull pauses inside the directory store's own page load, under the commit lease.
[Test]
public void RepullNeverErasesAStagedWriteOnDirectoryStore()
{
var store = DirectoryStore(PathOf("repull-dir.cc"));
using (var seed = store.Open())
Assert.That(seed.Commit(batch => batch.Upsert(new Slow { Name = "slow", Blocks = true })), Is.True);
using var cache = store.Open();
var staged = new CultRecordKey("staged");
using (var release = new ManualResetEventSlim())
{
Slow.Entered.Reset();
Slow.ReadWhilePaused = false;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
Slow.Pause = release;
try
{
var pulling = Task.Run(() => cache.PullAllBackingStoresAsync());
Assert.That(Slow.Entered.Wait(TimeSpan.FromSeconds(10)), Is.True, "the pull never loaded a page");
// Admitting the write indexes its name under the gate, so a write that gets past the gate reads it while paused.
using var started = new ManualResetEventSlim();
var writing = Task.Run(() =>
{
started.Set();
return cache.UpsertAsync(new Slow { Name = "staged" }, new CultRecordHandle<Slow>(staged));
});
Assert.That(started.Wait(TimeSpan.FromSeconds(10)), Is.True, "the writer never started");
writing.Wait(200);
Assert.That(Slow.ReadWhilePaused, Is.False, "a write was admitted while the pull held the gate");
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
Slow.Pause = null;
release.Set();
Assert.That(Task.WaitAll(new Task[] { pulling, writing }, TimeSpan.FromSeconds(10)), Is.True);
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
}
finally
{
Slow.Pause = null;
release.Set();
}
}
Assert.That(cache.Get(staged), Is.Not.Null, "the re-pull erased a staged write from the cache");
cache.FlushAllBackingStores();
using var reader = store.Open();
Assert.That(reader.Get(staged), Is.Not.Null, "the flush after the re-pull lost the staged write");
}
// Gate sharing is what makes a direct store call wait for its cache's I/O instead of interleaving with it.
[Test]
public void DirectCallsOnAnAttachedStoreShareTheCacheGate()
{
var path = PathOf("direct.cc");
Create(SingleFile(path), 0);
var store = new PausingStore(path);
using var cache = new CultCache(Registry);
cache.AddBackingStore(store);
using var release = new ManualResetEventSlim();
store.Pause = release;
try
{
var pulling = Task.Run(() => cache.PullAllBackingStoresAsync());
Assert.That(store.Entered.Wait(TimeSpan.FromSeconds(10)), Is.True, "the pull never read the file");
var pushing = Task.Run(() => store.PushAll());
Assert.That(pushing.Wait(200), Is.False, "a direct PushAll ran while the cache's pull held the gate");
store.Pause = null;
release.Set();
Assert.That(Task.WaitAll(new[] { pulling, pushing }, TimeSpan.FromSeconds(10)), Is.True);
}
finally
{
// A failed assert must not leave the pull parked on the gate that Dispose needs.
store.Pause = null;
release.Set();
}
}
[Test]
public void ObserverDoesNotRunUnderTheGate()
{
var path = PathOf("observer.cc");
using var cache = SingleFile(path).Open();
var gated = new System.Collections.Concurrent.ConcurrentQueue<string>();
var seen = 0;
using var subscription = cache.Watch<Counter>().Subscribe(change =>
{
Interlocked.Increment(ref seen);
if (!Task.Run(() => cache.Get(change.Key)).Wait(TimeSpan.FromSeconds(5)))
gated.Enqueue(change.Key.Value);
});
cache.UpsertAsync(new Counter { Name = "upserted" }, new CultRecordHandle<Counter>(new CultRecordKey("upserted")));
Assert.That(cache.Commit(batch => batch.Upsert(new Counter { Name = "committed" }, new CultRecordHandle<Counter>(new CultRecordKey("committed")))), Is.True);
using (var other = SingleFile(path).Open())
Assert.That(other.Commit(batch => batch.Upsert(new Counter { Name = "pulled" }, new CultRecordHandle<Counter>(new CultRecordKey("pulled")))), Is.True);
cache.PullAllBackingStoresAsync();
Assert.That(seen, Is.EqualTo(3));
Assert.That(gated, Is.Empty, "an observer ran while the cache gate was held");
}
[Test]
public void ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord()
{
var store = SingleFile(PathOf("resurrect.cc"));
var doomed = new CultRecordKey("doomed");
var later = new CultRecordKey("later");
using (var seed = store.Open())
Assert.That(seed.Commit(batch =>
{
batch.Upsert(new Counter { Name = "doomed" }, new CultRecordHandle<Counter>(doomed));
batch.Upsert(new Counter { Name = "kept" });
}), Is.True);
using var a = store.Open();
using (var b = store.Open())
{
Assert.That(b.Remove(doomed), Is.True);
b.FlushAllBackingStores();
}
var throwing = true;
a.OnUpdate += (_, _) =>
{
if (throwing)
throw new InvalidOperationException("observer failed");
};
Assert.That(() => a.PullAllBackingStoresAsync(), Throws.InvalidOperationException.With.Message.EqualTo("observer failed"));
throwing = false;
Assert.That(a.Get(doomed), Is.Null);
a.UpsertAsync(new Counter { Name = "later" }, new CultRecordHandle<Counter>(later));
a.FlushAllBackingStores();
using var reader = store.Open();
Assert.That(reader.Get(later), Is.Not.Null);
Assert.That(reader.Get(doomed), Is.Null, "a throwing observer left the store holding a record the cache dropped");
}
[Test]
public void OwnChangeIsPublishedBeforeWriteReturns()
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
{
using var cache = SingleFile(PathOf("own.cc")).Open();
var published = new ConcurrentDictionary<string, int>();
using var subscription = cache.Watch<Counter>().Subscribe(change => published[change.Key.Value] = Environment.CurrentManagedThreadId);
var late = 0;
var writers = Enumerable.Range(0, 4).Select(t => Task.Run(() =>
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
{
for (var i = 0; i < 3000; i++)
{
var key = $"{t}:{i}";
cache.UpsertAsync(new Counter { Name = key }, new CultRecordHandle<Counter>(new CultRecordKey(key)));
if (!published.TryGetValue(key, out var thread) || thread != Environment.CurrentManagedThreadId)
Interlocked.Increment(ref late);
}
})).ToArray();
Assert.That(Task.WaitAll(writers, TimeSpan.FromSeconds(60)), Is.True);
Assert.That(late, Is.Zero, "a write returned before its own change was published on its thread");
Assert.That(published.Count, Is.EqualTo(12000));
}
[Test]
public void ThrowingObserverDoesNotLoseOtherChanges()
{
var store = DirectoryStore(PathOf("throwing.cc"));
using var a = store.Open();
using var other = store.Open();
var loads = 0;
var armed = 0;
a.OnUpdate += (_, _) =>
{
Interlocked.Increment(ref loads);
if (Interlocked.Exchange(ref armed, 0) == 1)
throw new InvalidOperationException("observer failed");
};
var published = new ConcurrentDictionary<string, int>();
using var subscription = a.Watch<Counter>().Subscribe(change => published[change.Key.Value] = Environment.CurrentManagedThreadId);
var failed = 0;
var late = 0;
using var stop = new CancellationTokenSource();
var writing = Task.Run(() =>
{
for (var i = 0; !stop.IsCancellationRequested; i++)
{
var key = $"w:{i}";
try
{
a.UpsertAsync(new Counter { Name = key }, new CultRecordHandle<Counter>(new CultRecordKey(key)));
if (!published.TryGetValue(key, out var thread) || thread != Environment.CurrentManagedThreadId)
Interlocked.Increment(ref late);
}
catch (Exception)
{
Interlocked.Increment(ref failed);
}
}
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
});
try
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
{
for (var pull = 0; pull < 50; pull++)
{
var first = new CultRecordKey($"first:{pull}");
var second = new CultRecordKey($"second:{pull}");
Assert.That(other.Commit(batch =>
{
batch.Upsert(new Counter { Name = first.Value }, new CultRecordHandle<Counter>(first));
batch.Upsert(new Counter { Name = second.Value }, new CultRecordHandle<Counter>(second));
}), Is.True);
Interlocked.Exchange(ref armed, 1);
Assert.That(() => a.PullAllBackingStoresAsync(), Throws.InvalidOperationException.With.Message.EqualTo("observer failed"), $"pull {pull}");
Assert.That(loads, Is.EqualTo(2 * (pull + 1)), $"pull {pull} lost a change after its observer threw");
Assert.That(published.ContainsKey(second.Value), Is.True, $"pull {pull} never published its second record");
}
}
finally
{
stop.Cancel();
Assert.That(writing.Wait(TimeSpan.FromSeconds(10)), Is.True);
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
}
Assert.That(failed, Is.Zero, "an unrelated write threw another call's observer exception");
Assert.That(late, Is.Zero, "an unrelated write returned before its change was published");
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
}
[Test]
public void UnconditionalCommitIsLastWriterWinsLikeFlush()
{
var committed = LastWriter(SingleFile(PathOf("commit.cc")), (cache, key) =>
Assert.That(cache.Commit(batch => batch.Upsert(new Counter { Name = key.Value }, new CultRecordHandle<Counter>(key))), Is.True));
var flushed = LastWriter(SingleFile(PathOf("flush.cc")), (cache, key) =>
{
cache.UpsertAsync(new Counter { Name = key.Value }, new CultRecordHandle<Counter>(key));
cache.FlushAllBackingStores();
});
Assert.That(committed, Is.EqualTo(new[] { "a", "x" }), "an unconditional commit kept a record its cache never saw");
Assert.That(committed, Is.EqualTo(flushed));
// A directory store's flush lands staged keys onto the current manifest, and its commit does exactly the same.
var directoryCommitted = LastWriter(DirectoryStore(PathOf("commit-dir.cc")), (cache, key) =>
Assert.That(cache.Commit(batch => batch.Upsert(new Counter { Name = key.Value }, new CultRecordHandle<Counter>(key))), Is.True));
var directoryFlushed = LastWriter(DirectoryStore(PathOf("flush-dir.cc")), (cache, key) =>
{
cache.UpsertAsync(new Counter { Name = key.Value }, new CultRecordHandle<Counter>(key));
cache.FlushAllBackingStores();
});
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
Assert.That(directoryCommitted, Is.EqualTo(new[] { "a", "c", "x" }), "a directory commit dropped a key another writer added");
Assert.That(directoryCommitted, Is.EqualTo(directoryFlushed));
}
[Test]
public void UnconditionalCommitPersistsStagedWrites()
{
var path = PathOf("staged.cc");
using var cache = SingleFile(path).Open();
cache.UpsertAsync(new Counter { Name = "s" }, new CultRecordHandle<Counter>(new CultRecordKey("s")));
Assert.That(cache.Commit(batch => batch.Upsert(new Counter { Name = "y" }, new CultRecordHandle<Counter>(new CultRecordKey("y")))), Is.True);
Assert.That(cache.IsDirty, Is.False);
using var reader = SingleFile(path).Open();
Assert.That(reader.AllStoredDocuments.Select(stored => stored.Key.Value), Is.EqualTo(new[] { "s", "y" }));
}
[Test]
public void OpeningACorruptStoreThrowsAndLeavesItUntouched()
{
foreach (var store in new[] { SingleFile(PathOf("corrupt.cc")), DirectoryStore(PathOf("corrupt-dir.cc")) })
{
File.WriteAllBytes(store.Path, new byte[] { 0xC1, 0x00, 0xFF, 0x13 });
Assert.That(() => store.Open(), Throws.Exception, $"{store.Path}: a corrupt store opened");
Assert.That(File.ReadAllBytes(store.Path), Is.EqualTo(new byte[] { 0xC1, 0x00, 0xFF, 0x13 }), $"{store.Path}: opening rewrote a corrupt store");
}
var unknown = PathOf("unknown-schema.cc");
using (var writer = SingleFile(unknown).Open())
{
writer.UpsertAsync(new Tally { Name = "t" });
writer.FlushAllBackingStores();
}
var bytes = File.ReadAllBytes(unknown);
using var narrow = new CultCache(CultDocumentRegistry.ForTypes(new[] { typeof(Counter) }));
Assert.That(() => narrow.AddBackingStore(new SingleFileMessagePackBackingStore(unknown)), Throws.Exception, "a store with an unknown schema opened");
Assert.That(File.ReadAllBytes(unknown), Is.EqualTo(bytes), "opening rewrote a store with an unknown schema");
}
// A pulls {a}; B commits c; A writes x. Returns the keys on disk afterwards.
private static string[] LastWriter(StoreFactory store, Action<CultCache, CultRecordKey> write)
{
using (var seed = store.Open())
Assert.That(seed.Commit(batch => batch.Upsert(new Counter { Name = "a" }, new CultRecordHandle<Counter>(new CultRecordKey("a")))), Is.True);
using var a = store.Open();
using (var b = store.Open())
Assert.That(b.Commit(batch => batch.Upsert(new Counter { Name = "c" }, new CultRecordHandle<Counter>(new CultRecordKey("c")))), Is.True);
write(a, new CultRecordKey("x"));
using var reader = store.Open();
return reader.AllStoredDocuments.Select(stored => stored.Key.Value).ToArray();
}
private static void StaleExpect(StoreFactory store)
{
Create(store, 0);
using var a = store.Open();
using var b = store.Open();
Assert.That(Increment(a), Is.True);
var before = File.ReadAllBytes(store.Path);
var observedByB = b.Get<Counter>(Key)!;
var changes = 0;
using var subscription = b.Watch<Counter>().Subscribe(_ => changes++);
Assert.That(Commit(b, observedByB, 100), Is.False, $"{store.Path}: b's stale Expect committed");
Assert.That(File.ReadAllBytes(store.Path), Is.EqualTo(before));
Assert.That(b.Get<Counter>(Key), Is.SameAs(observedByB));
Assert.That(b.IsDirty, Is.False);
Assert.That(changes, Is.Zero);
}
private static void CreateOnce(StoreFactory store)
{
using var a = store.Open();
using var b = store.Open();
Assert.That(CreateCommit(a, 1), Is.True);
Assert.That(CreateCommit(b, 2), Is.False, $"{store.Path}: a second create-once commit won");
using var reader = store.Open();
Assert.That(reader.Get<Counter>(Key)!.Value, Is.EqualTo(1));
}
private static void UnrelatedWrite(StoreFactory store)
{
Create(store, 0);
using var a = store.Open();
using var b = store.Open();
Assert.That(a.Commit(batch => batch.Upsert(new Counter { Name = "b" }, new CultRecordHandle<Counter>(new CultRecordKey("b")))), Is.True);
Assert.That(Increment(b), Is.True, $"{store.Path}: an unrelated write failed a per-entry condition");
using var reader = store.Open();
Assert.That(reader.Get<Counter>(Key)!.Value, Is.EqualTo(1));
Assert.That(reader.Get(new CultRecordKey("b")), Is.Not.Null, $"{store.Path}: the commit dropped a record it never loaded");
}
private static void UnrelatedInsert(StoreFactory store)
{
Create(store, 0);
using var a = store.Open();
using var b = store.Open();
Assert.That(a.Commit(batch => batch.Upsert(new Counter { Name = "c" }, new CultRecordHandle<Counter>(new CultRecordKey("c")))), Is.True);
Assert.That(b.Commit(batch =>
{
batch.ExpectUnchanged();
batch.Upsert(new Counter { Name = "counter", Value = 5 }, new CultRecordHandle<Counter>(Key));
}), Is.False, $"{store.Path}: ExpectUnchanged ignored an insert");
}
private static void Create(StoreFactory store, int value)
{
using var cache = store.Open();
Assert.That(CreateCommit(cache, value), Is.True);
}
private static bool CreateCommit(CultCache cache, int value) => cache.Commit(batch =>
{
batch.Expect(Key, null);
batch.Upsert(new Counter { Name = "counter", Value = value }, new CultRecordHandle<Counter>(Key));
});
private static bool Increment(CultCache cache)
{
var observed = cache.Get<Counter>(Key)!;
return Commit(cache, observed, observed.Value + 1);
}
private static bool Commit(CultCache cache, Counter observed, int value) => cache.Commit(batch =>
{
batch.Expect(Key, observed);
batch.Upsert(new Counter { Name = "counter", Value = value }, new CultRecordHandle<Counter>(Key));
});
// One writer's delivery is parked in an observer; other writers, whose observers write the same cache, finish.
// The cache is not disposed on failure because a stuck delivery would hang disposal too.
[Test]
public void ObserverWritingTheSameCacheDoesNotWaitOnOtherDeliveries()
{
var cache = new CultCache(Registry);
using var release = new ManualResetEventSlim();
using var parked = new ManualResetEventSlim();
using var park = cache.Watch<Counter>().Subscribe(change =>
{
if (change.Key.Value != "parked") return;
parked.Set();
release.Wait(TimeSpan.FromSeconds(30));
});
using var tallies = cache.Watch<Counter>().Subscribe(change =>
cache.UpsertAsync(new Tally { Name = $"t:{change.Key.Value}" }, new CultRecordHandle<Tally>(new CultRecordKey($"t:{change.Key.Value}"))));
var parkedWriter = Task.Run(() => cache.UpsertAsync(new Counter { Name = "parked" }, new CultRecordHandle<Counter>(new CultRecordKey("parked"))));
Assert.That(parked.Wait(TimeSpan.FromSeconds(5)), Is.True);
var writers = Enumerable.Range(0, 8).Select(thread => Task.Run(() =>
{
for (var i = 0; i < 100; i++)
cache.UpsertAsync(new Counter { Name = $"c:{thread}", Value = i }, new CultRecordHandle<Counter>(new CultRecordKey($"c:{thread}")));
})).ToArray();
var finished = Task.WaitAll(writers, TimeSpan.FromSeconds(10));
release.Set();
Assert.That(finished, Is.True, "a writer waited on another thread's delivery");
Assert.That(parkedWriter.Wait(TimeSpan.FromSeconds(10)), Is.True);
cache.Dispose();
}
// Ordered by Sequence, each change replaces the document installed by the change before it.
[Test]
public void SequenceIncreasesInAdmissionOrder()
{
using var cache = new CultCache(Registry);
var key = new CultRecordKey("ordered");
var observed = new ConcurrentBag<CultCacheDocumentChange<Counter>>();
using var subscription = cache.Watch<Counter>().Subscribe(observed.Add);
var writers = Enumerable.Range(0, 8).Select(_ => Task.Run(() =>
{
for (var i = 0; i < 2000; i++)
cache.UpsertAsync(new Counter { Name = "ordered", Value = i }, new CultRecordHandle<Counter>(key));
})).ToArray();
Assert.That(Task.WaitAll(writers, TimeSpan.FromSeconds(60)), Is.True);
var ordered = observed.OrderBy(change => change.Sequence).ToArray();
Assert.That(ordered, Has.Length.EqualTo(16000));
Assert.That(ordered.Select(change => change.Sequence).Distinct().Count(), Is.EqualTo(16000), "a Sequence repeated");
var broken = Enumerable.Range(1, ordered.Length - 1)
.FirstOrDefault(i => !ReferenceEquals(ordered[i].PreviousDocument, ordered[i - 1].Document));
Assert.That(broken, Is.EqualTo(0), "a change's previous document is not the one installed by the next-lower Sequence");
}
// Each read must hold the document of the highest-Sequence change at or below the read's Sequence.
[Test]
public void SequencedReadReflectsEveryChangeAtOrBelowItsSequence()
{
using var cache = new CultCache(Registry);
var key = new CultRecordKey("sequenced");
var handle = new CultRecordHandle<Counter>(key);
var changes = new ConcurrentBag<CultCacheDocumentChange<Counter>>();
using var subscription = cache.Watch<Counter>().Subscribe(changes.Add);
cache.UpsertAsync(new Counter { Name = "sequenced", Value = -1 }, handle);
var reads = new ConcurrentBag<(object? Document, long Sequence)>();
var writers = Enumerable.Range(0, 4).Select(_ => Task.Run(() =>
{
for (var i = 0; i < 2000; i++)
cache.UpsertAsync(new Counter { Name = "sequenced", Value = i }, handle);
})).ToArray();
var readers = Enumerable.Range(0, 4).Select(_ => Task.Run(() =>
{
while (!writers.All(writer => writer.IsCompleted))
reads.Add(cache.GetWithSequence(key));
})).ToArray();
Assert.That(Task.WaitAll(writers.Concat(readers).ToArray(), TimeSpan.FromSeconds(60)), Is.True);
var ordered = changes.OrderBy(change => change.Sequence).ToArray();
var sequences = ordered.Select(change => change.Sequence).ToArray();
Assert.That(reads, Is.Not.Empty);
foreach (var (document, sequence) in reads)
{
var index = Array.BinarySearch(sequences, sequence);
Assert.That(index, Is.GreaterThanOrEqualTo(0), "a read's Sequence names no admitted change");
Assert.That(document, Is.SameAs(ordered[index].Document), $"read at Sequence {sequence} missed a change at or below it");
}
}
private string PathOf(string fileName) => System.IO.Path.Combine(_directory, fileName);
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
private static readonly CultDocumentRegistry Registry = CultDocumentRegistry.ForTypes(new[] { typeof(Counter), typeof(Tally), typeof(Slow) });
private static StoreFactory SingleFile(string path) => new(path, () => new SingleFileMessagePackBackingStore(path));
private static StoreFactory DirectoryStore(string path) => new(path, () => new DirectoryMessagePackBackingStore(path));
// Pauses a pull between reading the file and handing the records to the cache.
private sealed class PausingStore : SingleFileMessagePackBackingStore
{
public PausingStore(string path) : base(path)
{
}
public ManualResetEventSlim? Pause;
public readonly ManualResetEventSlim Entered = new();
public volatile bool Paused;
public volatile bool PushedWhilePaused;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
public override void Push(CultStoredDocument entry)
{
if (Paused)
PushedWhilePaused = true;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
base.Push(entry);
}
protected override CultPersistedStoreSnapshot DeserializeSnapshot(byte[] data)
{
var snapshot = base.DeserializeSnapshot(data);
if (Pause is { } pause)
{
Paused = true;
Entered.Set();
pause.Wait();
Paused = false;
}
return snapshot;
}
}
private sealed class StoreFactory
{
private readonly Func<CacheBackingStore> _create;
public StoreFactory(string path, Func<CacheBackingStore> create)
{
Path = path;
_create = create;
}
public string Path { get; }
public CultCache Open()
{
var cache = new CultCache(Registry);
cache.AddBackingStore(_create());
return cache;
}
}
[CultDocument("tests.conditional_counter", "tests.conditional_counter.v1")]
[MessagePackObject(AllowPrivate = true)]
internal sealed class Counter
{
[Key(0)]
[CultName]
public string Name = string.Empty;
[Key(1)]
public int Value;
}
[CultDocument("tests.conditional_tally", "tests.conditional_tally.v1")]
[MessagePackObject(AllowPrivate = true)]
internal sealed class Tally
{
[Key(0)]
[CultName]
public string Name = string.Empty;
}
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
// Loading a record with Blocks set waits on Pause, which parks a directory pull inside its page load.
[CultDocument("tests.conditional_slow", "tests.conditional_slow.v1")]
[MessagePackObject(AllowPrivate = true)]
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
internal sealed class Slow
{
internal static volatile ManualResetEventSlim? Pause;
internal static readonly ManualResetEventSlim Entered = new();
internal static volatile bool Paused;
internal static volatile bool ReadWhilePaused;
[IgnoreMember] private bool _blocks;
[IgnoreMember] private string _name = string.Empty;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
[Key(0)]
[CultName]
public string Name
{
get
{
if (Paused)
ReadWhilePaused = true;
return _name;
}
set => _name = value;
}
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
[Key(1)]
public bool Blocks
{
get => _blocks;
set
{
_blocks = value;
if (value && Pause is { } pause)
{
Paused = true;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
Entered.Set();
pause.Wait();
Paused = false;
Publish observers after the gate, gate every store entry point, stamp under one hold Observers and OnUpdate never run under the cache gate. Admit queues changes while the gate is held; the outermost entry point (attach, pull, commit, upsert, remove) publishes them after releasing it. A store's direct PullAll hands over an empty load outside its lock so the cache publishes then. A throwing observer can no longer split store from cache: publication starts only after the store has adopted its loaded view. The directory store adopts its durable catalog only after the cache admits the load; the write-only _durableIndex is deleted. Single-file Push, Delete, PushAll and CommitBatch take the gate like the directory store; Dispose flushes under it. Write mints storedAt and admits under one gate hold, and Land re-stamps staged upserts under the gate that admits them, so a concurrent pull cannot land a later storedAt in between. Tests: ObserverDoesNotRunUnderTheGate, ThrowingOnUpdateHandlerDoesNotResurrectDeletedRecord, RepullNeverErasesAStagedWriteOnDirectoryStore, DirectCallsOnAnAttachedStoreShareTheCacheGate; the directory last-writer result is pinned to {a,c,x}; the single-file re-pull test waits for the write to reach the store or block instead of sleeping. Pausing tests always release the pause so a failure cannot deadlock Dispose. Docs: observer rule, direct store calls share the gate, directory TryCommit contention and gate wait, per-key last-writer-wins, directory flush merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 19:23:44 +02:00
}
}
}
}
}
}