GameCult/Bifrost
Watch
9
0
Fork
You've already forked Bifrost
 0
Code Issues 7 Pull requests 5 Projects Releases Packages Wiki Activity Actions

Dashboard OpenMotions count includes sealed-ballot motions (DashboardSnapshotService.cs:185) #29

New issue
Open
opened 2026-11-09 22:06:05 +00:00 by heimdall · 0 comments
heimdall commented 2026-11-09 22:06:05 +00:00
Member
Copy link

DashboardSnapshotService.cs:185 computes OpenMotions as Status == Open && ClosesAtUtc >= now with no Kind filter. The open-motions list at line 29-32 was filtered to Kind == MotionKind.Standard by #21, and MotionGovernanceService.GetStateAsync (line 148) is filtered too, so the dashboard shows a count that includes open sealed-ballot motions while the list beside it and the motions page exclude them.

Expected: the count uses Kind == MotionKind.Standard, matching the list. Cosmetic (a number on the dashboard), no data effect.

Found while reading 55b74275..416f11ad4f17 for the deploy hold. Fix is one && x.Kind == MotionKind.Standard and a test that an open sealed motion leaves OpenMotions unchanged.

`DashboardSnapshotService.cs:185` computes `OpenMotions` as `Status == Open && ClosesAtUtc >= now` with no `Kind` filter. The open-motions list at line 29-32 was filtered to `Kind == MotionKind.Standard` by #21, and `MotionGovernanceService.GetStateAsync` (line 148) is filtered too, so the dashboard shows a count that includes open sealed-ballot motions while the list beside it and the motions page exclude them. Expected: the count uses `Kind == MotionKind.Standard`, matching the list. Cosmetic (a number on the dashboard), no data effect. Found while reading `55b74275..416f11ad4f17` for the deploy hold. Fix is one `&& x.Kind == MotionKind.Standard` and a test that an open sealed motion leaves `OpenMotions` unchanged.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
heimdall/mill-ranked-read
heimdall/desk-bifrost-half
mouth-open-direct
docs/dump-readable-by-restore
heimdall/mouth-read-through
heimdall/ratatoskr-voting-auth
heimdall/scope-cultlib-ts-names
heimdall/reserved-identities
heimdall/bifrost-guest-accounts
heimdall/sealed-key-path
heimdall/standard-close-concurrency
heimdall/sealed-mind-intake
heimdall/sealed-ballot-motion
heimdall/deploy-main-plan
eureka/deploy-plan-revise
heimdall/feedback-receiver
heimdall/delete-publish-workflow
heimdall/workflow-runs-on-docker
heimdall/host-only-cookies
heimdall/pin-vote-refusal-branches
heimdall/mouth-receipts-presence
heimdall/chat-images-cut-a
heimdall/estate-sim-purchased-stake
heimdall/credit-arm
heimdall/stale-estate-numbers
heimdall/stake-vectors
heimdall/estate-rule-sim
heimdall/charter-amendment-proposal
heimdall/mouth-media-line
eureka-body/optimistic-send-mouth
eureka-body/mouth-context-from-matrix
eureka-body/mouth-per-persona-rooms
eureka-body/mouth-many-peers
gamecult-chat/bifrost-oidc-backchannel-logout
gamecult-chat/bifrost-oidc-issuer
security/bifrost-dependency-pins
hands/heimdall-callback-signed
hands/mill-votes-cut-5b
hands/mill-votes-cut-5
hands/mill-votes-cut-3
hands/mill-votes-cut-4
hands/mill-votes-cut-2
hands/mill-votes-cut-1
hands/mill-votes-cut-0a
hands/watchdog-bifrost-retry
hands/watchdog-bifrost-reader
hands/watchdog-bifrost-suite
hands/watchdog-bifrost-retire
codex/bifrost-migration-metadata
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Bifrost#29
No description provided.