GameCult/Bifrost
Watch
9
0
Fork
You've already forked Bifrost
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

Tally export Vary: plain append, no dedupe

Browse source 
The dedupe branch only added equivalent mutants; a repeated Origin token is
harmless.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-10 22:19:52 +02:00
commit dcc3425520
2 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/Bifrost.Web/Features/ConceptVotes/ConceptTallyExport.cs
View file

@ -1,7 +1,7 @@
using Bifrost.Web.Configuration;
using Microsoft.AspNetCore.Cors.Infrastructure;
using Microsoft.Extensions.Options;
using Microsoft.Extensions.Primitives;
using Microsoft.Net.Http.Headers;
namespace Bifrost.Web.Features.ConceptVotes;
@ -29,7 +29,7 @@ public static class ConceptTallyExport
// Replaces app.UseCors(): the one place the origin decision is made. Every response under the export route
// (200, 404, 304, preflight, refusal) varies by Origin, appended to any Vary already present, because the CORS
// headers differ by request Origin and a URL-keyed cache must not serve one variant to another. ASP.NET Core
// adds Vary: Origin itself only for policies of more than one origin; this policy has one.
// adds Vary: Origin itself only for policies of more than one origin; this policy has one, and a repeated token is harmless.
public static IApplicationBuilder UseConceptTallyCors(this IApplicationBuilder app)
{
app.Use((context, next) =>
@ -38,14 +38,7 @@ public static class ConceptTallyExport
{
context.Response.OnStarting(() =>
{
var vary = context.Response.Headers.Vary;
var varies = vary.Any(v => v is not null
&& v.Split(',').Any(t => t.Trim() is "*" || t.Trim().Equals("Origin", StringComparison.OrdinalIgnoreCase)));
if (!varies)
{
context.Response.Headers.Vary = StringValues.Concat(vary, "Origin");
}
context.Response.Headers.Append(HeaderNames.Vary, "Origin");
return Task.CompletedTask;
});
}

2
tests/Bifrost.Web.Tests/ConceptTallyExportTests.cs
View file

@ -166,7 +166,7 @@ public sealed class ConceptTallyExportTests : IClassFixture<ConceptTallyExportTe
}
[Fact]
public async Task Origin_is_added_to_an_existing_vary_and_not_repeated()
public async Task Origin_is_added_to_an_existing_vary()
{
var collection = NewCollection();
await AddSubject(collection, "alpha");