diff --git a/tests/Bifrost.Web.Tests/FakeHeimdallMoverTests.cs b/tests/Bifrost.Web.Tests/FakeHeimdallMoverTests.cs new file mode 100644 index 0000000..b1311a5 --- /dev/null +++ b/tests/Bifrost.Web.Tests/FakeHeimdallMoverTests.cs @@ -0,0 +1,165 @@ +using System.Net; +using System.Text; +using Bifrost.Web.Tests.Support; + +namespace Bifrost.Web.Tests; + +/// +/// The fake mover is the spec the client is tested against, so it must refuse what Heimdall 4fe367a refuses, with the same status and code, in the +/// same order (app.ts moveIdentitiesRoute and its schema, identity-move.ts decideMove). Each case sends a raw body to the fake. +/// +public sealed class FakeHeimdallMoverTests +{ + private static string Id() => "move-" + Guid.NewGuid().ToString("N"); + + private static string Account() => HeimdallShapes.NewAccountId(); + + private static async Task<(HttpStatusCode Status, string Error)> Post(HeimdallHost host, string json) + { + using var client = new HttpClient(host.Heimdall, disposeHandler: false) { BaseAddress = new Uri("https://heimdall.test") }; + client.DefaultRequestHeaders.Add("x-heimdall-app-secret", HeimdallHost.AppSecret); + using var response = await client.PostAsync("/v1/apps/bifrost/identity-moves", new StringContent(json, Encoding.UTF8, "application/json")); + var body = await response.Content.ReadAsStringAsync(); + var error = System.Text.Json.JsonDocument.Parse(body).RootElement.TryGetProperty("error", out var e) ? e.GetString()! : ""; + return (response.StatusCode, error); + } + + private static string Move(string moveId, string[] from, string? to = null, string[]? ids = null, string? reverses = null) => + System.Text.Json.JsonSerializer.Serialize(new Dictionary + { + ["moveId"] = moveId, + ["fromProofs"] = from, + ["toProof"] = to, + ["identityIds"] = ids, + ["reversesMoveId"] = reverses + }.Where(x => x.Value is not null).ToDictionary()); + + [Fact] + public async Task A_body_the_routes_schema_rejects_is_a_400_and_moves_nothing() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + var login = moves.AddLogin(s, "discord"); + moves.AddLogin(d, "twitch"); + var forward = Id(); + Assert.Equal(HttpStatusCode.OK, (await Post(host, Move(forward, [moves.Issue(s, login, "bifrost-passkey")], moves.Issue(d)))).Status); + var (s2, d2) = (Account(), Account()); + var login2 = moves.AddLogin(s2, "patreon"); + moves.AddLogin(d2, "twitch"); + var strong = () => moves.Issue(s2, login2, "bifrost-passkey"); + + var bad = new[] + { + Move(Id(), [moves.Issue(d)], moves.Issue(s), reverses: forward), + Move(Id(), [strong()]), + Move(Id(), [strong()], reverses: "x"), + Move(Id(), [strong()], moves.Issue(d2), [login2, login2]), + Move(Id(), [""], "x"), + Move(Id(), [strong()], "x", [""]), + Move(Id(), [strong()], "x", []), + Move(Id(), [moves.Issue(d)], ids: [login], reverses: forward), + Move(Id(), [], "x"), + Move(Id(), Enumerable.Repeat("p", 9).ToArray(), "x"), + Move(Id(), [new string('p', 8193)], "x"), + Move("short", [strong()], "x"), + """{"moveId":"move-0123456789abcdef","fromProofs":"p","toProof":"x"}""", + "[]" + }; + foreach (var json in bad) + { + Assert.Equal(HttpStatusCode.BadRequest, (await Post(host, json)).Status); + } + + Assert.Single(moves.Stored); + Assert.Single(moves.Logins[s2]); + } + + [Fact] + public async Task A_source_holding_no_login_is_404_identity_not_found_not_an_empty_receipt() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + moves.AddLogin(d, "twitch"); + + var answer = await Post(host, Move(Id(), [moves.Issue(s, Guid.NewGuid().ToString(), "bifrost-passkey")], moves.Issue(d))); + + Assert.Equal((HttpStatusCode.NotFound, "identity_not_found"), answer); + } + + [Fact] + public async Task An_unheld_login_is_404_before_coverage_is_judged() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + var login = moves.AddLogin(s, "discord"); + moves.AddLogin(d, "twitch"); + + var answer = await Post(host, Move(Id(), [moves.Issue(s, login)], moves.Issue(d), [login, Guid.NewGuid().ToString()])); + + Assert.Equal((HttpStatusCode.NotFound, "identity_not_found"), answer); + } + + [Fact] + public async Task A_proof_that_covers_no_login_at_all_is_403_identity_not_proved_before_the_store_looks() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + moves.AddLogin(d, "twitch"); + + // No auth_identity_id and no passkey: nothing is covered, even though the source holds no login either. + Assert.Equal((HttpStatusCode.Forbidden, "identity_not_proved"), await Post(host, Move(Id(), [moves.Issue(s)], moves.Issue(d)))); + } + + [Fact] + public async Task A_future_dated_proof_proves_nothing() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + var login = moves.AddLogin(s, "discord"); + moves.AddLogin(d, "twitch"); + + Assert.Equal((HttpStatusCode.Forbidden, "proof_stale"), await Post(host, Move(Id(), [moves.Issue(s, login, authAgo: -60)], moves.Issue(d)))); + } + + [Fact] + public async Task A_replay_whose_proofs_are_not_signed_for_the_stored_accounts_is_409_move_id_conflict_not_proof_invalid() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d) = (Account(), Account()); + var login = moves.AddLogin(s, "discord"); + moves.AddLogin(d, "twitch"); + var id = Id(); + var to = moves.Issue(d); + Assert.Equal(HttpStatusCode.OK, (await Post(host, Move(id, [moves.Issue(s, login)], to))).Status); + + Assert.Equal((HttpStatusCode.Conflict, "move_id_conflict"), await Post(host, Move(id, ["forged-bearer"], to))); + Assert.Equal((HttpStatusCode.Conflict, "move_id_conflict"), await Post(host, Move(id, [moves.Issue(d)], to))); + Assert.Equal((HttpStatusCode.Conflict, "move_id_conflict"), await Post(host, Move(id, [moves.Issue(s)], reverses: Id()))); + Assert.Equal(HttpStatusCode.OK, (await Post(host, Move(id, [moves.Issue(s)], to))).Status); + } + + [Fact] + public async Task A_reversal_by_the_wrong_account_or_of_a_reversed_move_is_409_not_reversible_in_Heimdalls_order() + { + using var host = new HeimdallHost(); + var moves = host.Heimdall.Moves; + var (s, d, other) = (Account(), Account(), Account()); + var login = moves.AddLogin(s, "discord"); + moves.AddLogin(d, "twitch"); + moves.AddLogin(other, "google"); + var forward = Id(); + await Post(host, Move(forward, [moves.Issue(s, login, "bifrost-passkey")], moves.Issue(d))); + + // The wrong account proves the reversal: not_reversible only after its proof was judged live. + Assert.Equal((HttpStatusCode.Forbidden, "proof_invalid"), await Post(host, Move(Id(), ["unknown"], reverses: forward))); + Assert.Equal((HttpStatusCode.Conflict, "not_reversible"), await Post(host, Move(Id(), [moves.Issue(other, stepUpMethod: "bifrost-passkey")], reverses: forward))); + Assert.Equal((HttpStatusCode.OK, ""), await Post(host, Move(Id(), [moves.Issue(d, login, "bifrost-passkey")], reverses: forward))); + Assert.Equal((HttpStatusCode.Conflict, "not_reversible"), await Post(host, Move(Id(), [moves.Issue(d, stepUpMethod: "bifrost-passkey")], reverses: forward))); + } +} diff --git a/tests/Bifrost.Web.Tests/Support/FakeMoves.cs b/tests/Bifrost.Web.Tests/Support/FakeMoves.cs index b28a0c7..e1df159 100644 --- a/tests/Bifrost.Web.Tests/Support/FakeMoves.cs +++ b/tests/Bifrost.Web.Tests/Support/FakeMoves.cs @@ -137,25 +137,65 @@ public sealed class FakeMoves(Func now) private static readonly System.Text.RegularExpressions.Regex MoveIdShape = new("^[A-Za-z0-9_-]{16,64}$"); + /// + /// Heimdall's route schema (app.ts, the identity-moves route): moveId pattern, 1 to 8 fromProofs of 1 to 8192 chars, toProof, 1 to 32 + /// unique non-empty identityIds, reversesMoveId pattern; and oneOf: a forward move has toProof and no reversesMoveId, a reversal has + /// reversesMoveId and neither toProof nor identityIds. Unknown properties are stripped. Anything else is a 400. + /// private static Move? Parse(string body) { try { var root = JsonDocument.Parse(body).RootElement; - string? Text(string name) => root.TryGetProperty(name, out var v) && v.ValueKind == JsonValueKind.String ? v.GetString() : null; - string[]? List(string name) => root.TryGetProperty(name, out var v) && v.ValueKind == JsonValueKind.Array - ? v.EnumerateArray().Select(x => x.ValueKind == JsonValueKind.String ? x.GetString()! : null!).ToArray() - : null; - var from = List("fromProofs"); - var ids = List("identityIds"); - if (Text("moveId") is not { } id || !MoveIdShape.IsMatch(id) - || from is not { Length: >= 1 and <= 8 } || from.Any(x => x is null) - || ids is { Length: 0 or > 32 } || (ids is not null && ids.Any(x => x is null))) + if (root.ValueKind != JsonValueKind.Object) { return null; } - return new Move(id, from, Text("toProof"), ids, Text("reversesMoveId")); + var bad = false; + string? Text(string name, int min, int max, bool pattern) + { + if (!root.TryGetProperty(name, out var v)) + { + return null; + } + + if (v.ValueKind != JsonValueKind.String || v.GetString() is not { } t || t.Length < min || t.Length > max || (pattern && !MoveIdShape.IsMatch(t))) + { + bad = true; + return null; + } + + return t; + } + + string[]? List(string name, int max, int maxLength, bool unique) + { + if (!root.TryGetProperty(name, out var v)) + { + return null; + } + + if (v.ValueKind != JsonValueKind.Array || v.GetArrayLength() is 0 || v.GetArrayLength() > max + || v.EnumerateArray().Any(x => x.ValueKind != JsonValueKind.String || x.GetString() is not { Length: > 0 } t || t.Length > maxLength)) + { + bad = true; + return null; + } + + var items = v.EnumerateArray().Select(x => x.GetString()!).ToArray(); + bad |= unique && items.Distinct().Count() != items.Length; + return items; + } + + var id = Text("moveId", 16, 64, true); + var from = List("fromProofs", 8, 8192, false); + var to = Text("toProof", 1, 8192, false); + var ids = List("identityIds", 32, int.MaxValue, true); + var reverses = Text("reversesMoveId", 16, 64, true); + var forward = to is not null && reverses is null; + var reversal = reverses is not null && to is null && ids is null; + return bad || id is null || from is null || !(forward || reversal) ? null : new Move(id, from, to, ids, reverses); } catch (JsonException) { @@ -163,59 +203,62 @@ public sealed class FakeMoves(Func now) } } + /// moveIdentitiesRoute then decideMove at 4fe367a, in their order; each comment names the check. private (HttpResponseMessage? Refusal, string? Receipt) Decide(Move move) { var at = now().ToUnixTimeSeconds(); var reversal = move.ReversesMoveId is not null; - // Replay: registry match of app and accounts, liveness not checked. - var known = move.FromProofs.Select(Known).ToArray(); + // Replay: the stored move answers before any proof is judged live; proofs need only be signed for the stored accounts. if (_moves.TryGetValue(move.MoveId, out var stored)) { - if (known.Any(x => x is null) || known.Select(x => x!.Account).Distinct().Count() != 1) - { - return (Refuse(HttpStatusCode.Forbidden, "proof_invalid", proof: "from"), null); - } - - var toKnown = move.ToProof is null ? null : Known(move.ToProof); - if (move.ToProof is not null && toKnown is null) - { - return (Refuse(HttpStatusCode.Forbidden, "proof_invalid", proof: "to"), null); - } - - return known[0]!.Account == stored.From && toKnown?.Account == (reversal ? null : stored.To) && move.ReversesMoveId == stored.ReversesMoveId - ? (null, stored.Receipt) - : (Refuse(HttpStatusCode.Conflict, "move_id_conflict"), null); + var same = move.ReversesMoveId == stored.ReversesMoveId + && move.FromProofs.All(x => Known(x)?.Account == stored.From) + && (reversal ? move.ToProof is null : Known(move.ToProof!)?.Account == stored.To); + return same ? (null, stored.Receipt) : (Refuse(HttpStatusCode.Conflict, "move_id_conflict"), null); } StoredMove? forward = null; - if (reversal && !(_moves.TryGetValue(move.ReversesMoveId!, out forward) && forward.ReversesMoveId is null && !forward.Reversed - && (known[0] is not { } holder || holder.Account == forward.To))) + if (reversal && !(_moves.TryGetValue(move.ReversesMoveId!, out forward) && forward.ReversesMoveId is null)) { return (Refuse(HttpStatusCode.Conflict, "not_reversible"), null); } - // proof_invalid: not a live bearer of this app, or fromProofs naming two accounts. - var from = move.FromProofs.Select(Live).ToArray(); - if (from.Any(x => x is null) || from.Select(x => x!.Account).Distinct().Count() != 1) + var from = new List(); + foreach (var token in move.FromProofs) + { + if (Live(token) is not { } claims) + { + return (Refuse(HttpStatusCode.Forbidden, "proof_invalid", proof: "from"), null); + } + + from.Add(claims); + } + + var source = from[0].Account; + if (from.Any(x => x.Account != source)) { return (Refuse(HttpStatusCode.Forbidden, "proof_invalid", proof: "from"), null); } - var to = move.ToProof is null ? null : Live(move.ToProof); - if (move.ToProof is not null && to is null) + Claims? to = null; + if (!reversal && (to = Live(move.ToProof!)) is null) { return (Refuse(HttpStatusCode.Forbidden, "proof_invalid", proof: "to"), null); } - var source = from[0]!.Account; - if (to is not null && to.Account == source) + if (reversal && source != forward!.To) + { + return (Refuse(HttpStatusCode.Conflict, "not_reversible"), null); + } + + var destination = to?.Account ?? forward!.From; + if (source == destination) { return (Refuse(HttpStatusCode.Conflict, "same_account"), null); } - // proof_stale: weak 300 s by auth_at, strong 600 s by step_up_at, the host clock. - if (from.Any(x => Tier(x!, at) is null)) + if (from.Any(x => Tier(x, at) is null)) { return (Refuse(HttpStatusCode.Forbidden, "proof_stale", proof: "from"), null); } @@ -225,26 +268,44 @@ public sealed class FakeMoves(Func now) return (Refuse(HttpStatusCode.Forbidden, "proof_stale", proof: "to"), null); } - var held = Logins.GetValueOrDefault(source) ?? []; - var carried = reversal ? forward!.Carried.ToArray() : move.IdentityIds ?? held.Select(x => x.Id).ToArray(); - var whole = from.Any(x => Tier(x!, at) == "strong" && x!.StepUpMethod == "bifrost-passkey"); - if (!whole && carried.Any(id => from.All(x => x!.AuthIdentityId != id))) + // proofCovers: a strong passkey proof speaks for the account, else the login the sign-in came through, else nothing. + var coverage = from.Select(x => Tier(x, at) == "strong" && x.StepUpMethod == "bifrost-passkey" ? "account" : x.AuthIdentityId).ToArray(); + if (coverage.All(x => x is null)) { return (Refuse(HttpStatusCode.Forbidden, "identity_not_proved"), null); } - var destination = reversal ? forward!.From : to!.Account; - if (!reversal && (IsAlias(source) || IsAlias(destination))) + // decideMove: reversal or alias, the logins chosen (held ones only), coverage of them, then the destination's providers. + var held = Logins.GetValueOrDefault(source) ?? []; + if (reversal) + { + if (forward!.Reversed || forward.Carried.Any(id => held.All(x => x.Id != id))) + { + return (Refuse(HttpStatusCode.Conflict, "not_reversible"), null); + } + } + else if (IsAlias(source) || IsAlias(destination)) { return (Refuse(HttpStatusCode.Conflict, "already_moved"), null); } - if (carried.Any(id => held.All(x => x.Id != id))) + var wanted = reversal ? forward!.Carried : move.IdentityIds; + if (wanted is not null && wanted.Any(id => held.All(x => x.Id != id))) { return (Refuse(HttpStatusCode.NotFound, "identity_not_found"), null); } - var moving = held.Where(x => carried.Contains(x.Id)).ToList(); + var moving = held.Where(x => wanted is null || wanted.Contains(x.Id)).ToList(); + if (moving.Count == 0) + { + return (Refuse(HttpStatusCode.NotFound, "identity_not_found"), null); + } + + if (!coverage.Contains("account") && moving.Any(x => !coverage.Contains(x.Id))) + { + return (Refuse(HttpStatusCode.Forbidden, "identity_not_proved"), null); + } + var there = Logins.GetValueOrDefault(destination) ?? []; if (moving.FirstOrDefault(x => there.Any(y => y.Provider == x.Provider)) is { } clash) { @@ -259,22 +320,27 @@ public sealed class FakeMoves(Func now) _revoked.Add(claims.Sid); } - var strong = from.Any(x => Tier(x!, at) == "strong"); - var receipt = JsonSerializer.Serialize(new Dictionary + var strong = from.Any(x => Tier(x, at) == "strong"); + var receipt = new Dictionary { ["moveId"] = move.MoveId, ["accountId"] = destination, ["movedIdentityIds"] = moving.Select(x => x.Id).ToArray(), - ["proof"] = new Dictionary { ["from"] = strong ? "strong" : "weak", ["to"] = to is null ? null : Tier(to, at) }, - ["reversesMoveId"] = move.ReversesMoveId - }.Where(x => x.Key != "reversesMoveId" || x.Value is not null).ToDictionary()); - _moves[move.MoveId] = new StoredMove(move.MoveId, source, destination, move.ReversesMoveId, moving.Select(x => x.Id).ToArray(), receipt); + ["proof"] = new Dictionary { ["from"] = strong ? "strong" : "weak", ["to"] = to is null ? null : Tier(to, at) } + }; + if (move.ReversesMoveId is not null) + { + receipt["reversesMoveId"] = move.ReversesMoveId; + } + + var json = JsonSerializer.Serialize(receipt); + _moves[move.MoveId] = new StoredMove(move.MoveId, source, destination, move.ReversesMoveId, moving.Select(x => x.Id).ToArray(), json); if (forward is not null) { forward.Reversed = true; } - return (null, receipt); + return (null, json); } private bool IsAlias(string account) => @@ -285,8 +351,10 @@ public sealed class FakeMoves(Func now) private Claims? Live(string token) => Known(token) is { } claims && !_revoked.Contains(claims.Sid) && claims.Exp > now().ToUnixTimeSeconds() ? claims : null; + /// proofTier: strong inside 600 s of step_up_at, else weak inside 300 s of auth_at; a future-dated claim proves nothing. private static string? Tier(Claims claims, long at) => - claims.StepUpAt is { } stepUp && at - stepUp <= StrongSeconds ? "strong" : at - claims.AuthAt <= WeakSeconds ? "weak" : null; + claims.StepUpAt is { } stepUp && stepUp <= at && at - stepUp <= StrongSeconds ? "strong" + : claims.AuthAt <= at && at - claims.AuthAt <= WeakSeconds ? "weak" : null; private static HttpResponseMessage Json(HttpStatusCode status, string json) => new(status) { Content = new StringContent(json, Encoding.UTF8, "application/json") };