earcon-workshop: review fixes (check count 882, lowpass comment says two poles)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Aqua 2026-11-06 05:36:46 +00:00
commit 33a4ccc0f2
2 changed files with 2 additions and 2 deletions

View file

@ -32,7 +32,7 @@ Never opened on a real display by a person. A headless Chromium smoke (load, aud
## What the check covers (`test.mjs`)
For each identity x event at the default setting and at two slider extremes (881 checks at the time of writing):
For each identity x event at the default setting and at two slider extremes (882 checks at the time of writing):
- finite, non-silent, onset (first sample at or above -40 dBFS) under 20 ms, sample peak < 1.0 and <= 0.9, true peak < 1.0 (cross-checked
with `tools/aqua-feel/metrics.js`), no over-full-scale samples or flat tops, ends without a step, under 2.6 s, WAV round trip.

View file

@ -46,7 +46,7 @@ export function clampParams(p = {}) {
const TAU = Math.PI * 2;
// One note into `out` at sample `start`. Linear attack (<= 6 ms), exponential decay reaching -60 dB at `decaySec`,
// one-pole lowpass whose cutoff follows brightness, 3 ms linear fade at the voice end so no tail ends on a step.
// two-pole lowpass (two cascaded one-pole stages) whose cutoff follows brightness, 3 ms linear fade at the voice end so no tail ends on a step.
function addNote(out, start, hz, gain, id, decaySec, bright) {
const len = Math.min(out.length - start, Math.ceil(decaySec * SR));
if (len <= 0) return;