GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cargo give: the bay no longer holds a stack below one, so the give's positive-stack filter and its zero-stack test go

Browse source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
soul 2026-10-22 22:15:41 +02:00
commit fa5820f516
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Assets/Scripts/ServerShared/CargoTransfer.cs
View file

@ -110,7 +110,7 @@ public static class CargoTransfer
} }
else if (bay.ItemsOfType.TryGetValue(order.Item.Data.Key, out var stacks)) else if (bay.ItemsOfType.TryGetValue(order.Item.Data.Key, out var stacks))
{ {
var stack = stacks.OfType<SimpleCommodity>().FirstOrDefault(s => s.Quantity > 0); var stack = stacks.OfType<SimpleCommodity>().FirstOrDefault();
if (stack != null) return (bay, stack); if (stack != null) return (bay, stack);
} }
} }

5
tests/Aetheria.Shared.Tests/CargoTransferTests.cs
View file

@ -697,15 +697,14 @@ public sealed class CargoTransferTests : IDisposable
Assert.Equal(5, order.Remaining); Assert.Equal(5, order.Remaining);
} }
// An empty stack in a hold is no unit to give: the give moves the real units and then has nothing left. // A give of more than the hold has moves the real units and then has nothing left.
[Fact] [Fact]
public void AnEmptyStackIsNotAUnitToGive() public void AGiveOfMoreThanTheHoldHasEndsNothingLeft()
{ {
var giver = ShipWithBays("Crate"); var giver = ShipWithBays("Crate");
var receiver = ShipWithBays("Crate"); var receiver = ShipWithBays("Crate");
var grit = Commodity("Grit", 2); var grit = Commodity("Grit", 2);
Assert.True(giver.CargoBays[0].TryStore(grit)); Assert.True(giver.CargoBays[0].TryStore(grit));
Assert.True(giver.CargoBays[0].TryStore(Commodity("Grit", 0)));
Place(giver, receiver); Place(giver, receiver);
giver.Command.Give(receiver, grit, 3); giver.Command.Give(receiver, grit, 3);