From ae7eee7e06dfafdb085e361fe00d1b0385f7dcad Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Sun, 21 Jun 2026 13:13:56 +0100 Subject: [PATCH] Keep generic submit helpers internal --- Aetheria.State.Verify/Program.cs | 17 +++++++++++++++++ .../Runtime/AetheriaRuntimeCommandPort.cs | 4 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/Aetheria.State.Verify/Program.cs b/Aetheria.State.Verify/Program.cs index f2615a0f5..506e37018 100644 --- a/Aetheria.State.Verify/Program.cs +++ b/Aetheria.State.Verify/Program.cs @@ -6875,6 +6875,8 @@ static void RequireTypedEveCommandBodies(string root) "internal Task SubmitDaemonCommandAsync(", "internal Task SubmitEveCommandAsync(", "internal static class AetheriaRuntimeCommandSubmitter", + "internal static bool TrySubmitEveCommand(", + "internal static bool TrySubmitDaemonCommand(", "TrySubmitEveCommand(", "TrySubmitDaemonCommand(", "CreatePlayerSettingsCommand(", @@ -6999,6 +7001,21 @@ static void RequireTypedEveCommandBodies(string root) string.Join(", ", publicRuntimePortSubmitHits)); } + var forbiddenPublicSubmitterMethods = new[] + { + "public static bool TrySubmitDaemonCommand(", + "public static bool TrySubmitEveCommand(" + }; + var publicSubmitterMethodHits = forbiddenPublicSubmitterMethods + .Where(symbol => runtimeCommandPort.Contains(symbol, StringComparison.Ordinal)) + .ToArray(); + if (publicSubmitterMethodHits.Length > 0) + { + throw new InvalidOperationException( + "Runtime command submitter still marks generic submit helpers public instead of keeping them internal: " + + string.Join(", ", publicSubmitterMethodHits)); + } + var forbiddenUnitySubmitterSymbols = new[] { "AetheriaRuntimeCommandSubmitter.TrySubmitEveCommand(", diff --git a/Packages/org.gamecult.aetheria.state/Runtime/AetheriaRuntimeCommandPort.cs b/Packages/org.gamecult.aetheria.state/Runtime/AetheriaRuntimeCommandPort.cs index 296a62c46..d8762f4a6 100644 --- a/Packages/org.gamecult.aetheria.state/Runtime/AetheriaRuntimeCommandPort.cs +++ b/Packages/org.gamecult.aetheria.state/Runtime/AetheriaRuntimeCommandPort.cs @@ -191,7 +191,7 @@ namespace GameCult.Aetheria.State.Verse private static readonly Dictionary Ports = new Dictionary(StringComparer.OrdinalIgnoreCase); - public static bool TrySubmitDaemonCommand( + internal static bool TrySubmitDaemonCommand( string stateFilePath, AetheriaRuntimeDaemonCommandDocument command, string runtimeId, @@ -216,7 +216,7 @@ namespace GameCult.Aetheria.State.Verse } } - public static bool TrySubmitEveCommand( + internal static bool TrySubmitEveCommand( string stateFilePath, AetheriaRuntimeEveCommandDocument command, string runtimeId,