From a1d1db963f358fdaf8990f280a76b83554bf6cba Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Tue, 13 Oct 2026 08:00:26 +0200 Subject: [PATCH] contact-hud: RevealedSubjectsListsTheBook holds two subjects at once, then one departs Fixes finding revealed-subjects-multi-subject-unpinned. All commits build. Co-Authored-By: Claude Opus 5.5 --- tests/Aetheria.Shared.Tests/ContactRevealTests.cs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/Aetheria.Shared.Tests/ContactRevealTests.cs b/tests/Aetheria.Shared.Tests/ContactRevealTests.cs index 6c74ad801..b23960b95 100644 --- a/tests/Aetheria.Shared.Tests/ContactRevealTests.cs +++ b/tests/Aetheria.Shared.Tests/ContactRevealTests.cs @@ -1262,6 +1262,10 @@ public sealed partial class ContactRevealTests : IDisposable Fire(e, gun); Assert.True(o.RevealedSubjects.Count == 1 && o.RevealedSubjects.Contains(e)); + var q = Add(float3(40, 0, 100), new[] { "Gun" }); + Fire(q, Guns(q)[0]); + Assert.True(o.RevealedSubjects.Count == 2 && o.RevealedSubjects.Contains(e) && o.RevealedSubjects.Contains(q)); // two subjects at once: both listed + var freshest = Freshest(o, e); ShowOnly(e, 1f, gun); Assert.True(e.Visibility * o.PassiveInfo(e.Position.xz, 1f) <= _items.GameplaySettings.TargetDetectionInfoThreshold, "fixture: its last light is below o's gate"); @@ -1273,13 +1277,10 @@ public sealed partial class ContactRevealTests : IDisposable Tick(.1f); lapsed = _zone.Time - freshest >= memory; Assert.Equal(!lapsed, o.RevealedSubjects.Contains(e)); // exactly while the bearing is remembered + Assert.True(o.RevealedSubjects.Contains(q), "the other subject stays listed while e departs"); } Assert.True(lapsed, "fixture: the bearing lapsed"); - Assert.Equal(0, o.RevealedSubjects.Count); // counts, not the collection: a failure message would print whole entities - - var q = Add(float3(40, 0, 100), new[] { "Gun" }); - Fire(q, Guns(q)[0]); - Assert.True(o.RevealedSubjects.Count == 1 && o.RevealedSubjects.Contains(q)); + Assert.True(o.RevealedSubjects.Count == 1 && o.RevealedSubjects.Contains(q)); // only the departed one dropped o.Deactivate(); Assert.Equal(0, o.RevealedSubjects.Count); // counts, not the collection: a failure message would print whole entities }