Require typed keys in pending runtime commits
This commit is contained in:
parent
01fc810eb4
commit
a16b0559d4
7 changed files with 60 additions and 69 deletions
|
|
@ -9,6 +9,7 @@ var statePath = args.Length > 1
|
|||
|
||||
RequireGameplaySourcePurity(root);
|
||||
RequirePackageSerializerBoundary(root);
|
||||
RequireTypedPendingCommitKeys(root);
|
||||
RequireEveRuntimeBootstrap(root);
|
||||
RequireNoRendererLocalConsole(root);
|
||||
RequireNoRendererLocalDebugPanels(root);
|
||||
|
|
@ -583,6 +584,44 @@ static void RequirePackageSerializerBoundary(string root)
|
|||
}
|
||||
}
|
||||
|
||||
static void RequireTypedPendingCommitKeys(string root)
|
||||
{
|
||||
var checkedFiles = new[]
|
||||
{
|
||||
Path.Combine(root, "Packages", "org.gamecult.aetheria.state", "Runtime", "AetheriaRuntimeStateCommitDocument.cs"),
|
||||
Path.Combine(root, "Aetheria.State", "AetheriaRuntimeCommitLogApplier.cs")
|
||||
};
|
||||
|
||||
var forbiddenSymbols = new[]
|
||||
{
|
||||
"CorporationLegacyId",
|
||||
"OrbitLegacyId",
|
||||
"ParentLegacyId",
|
||||
"BodyLegacyId",
|
||||
"ResourceScannerTargetBodyId { get; set; }",
|
||||
"MiningToolAsteroidBeltId { get; set; }",
|
||||
"ReferenceKey(entity.FactionKey",
|
||||
"ReferenceKey(orbit.OrbitKey",
|
||||
"ReferenceKey(body.BodyKey",
|
||||
"ReferenceKey(relationship.FactionKey"
|
||||
};
|
||||
|
||||
var hits = checkedFiles
|
||||
.Where(File.Exists)
|
||||
.SelectMany(path => File.ReadLines(path)
|
||||
.Select((line, index) => new { Path = path, LineNumber = index + 1, Line = line }))
|
||||
.Where(line => forbiddenSymbols.Any(symbol => line.Line.Contains(symbol, StringComparison.Ordinal)))
|
||||
.Select(line => $"{Path.GetRelativePath(root, line.Path)}:{line.LineNumber}: {line.Line.Trim()}")
|
||||
.ToArray();
|
||||
|
||||
if (hits.Length > 0)
|
||||
{
|
||||
throw new InvalidOperationException(
|
||||
"Pending runtime commit authority still accepts legacy ID fallback fields: " +
|
||||
string.Join("; ", hits));
|
||||
}
|
||||
}
|
||||
|
||||
static void RequireEveRuntimeBootstrap(string root)
|
||||
{
|
||||
var bootstrapPath = Path.Combine(
|
||||
|
|
|
|||
Loading…
Reference in a new issue