GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Assert on the shot target and outcome identity without formatting entities

Browse source 
Assert.Null(shot.Target) and Assert.Same(committed, resolved) format the
entity graph when they fail, which overflows the xunit stack and crashes the
host instead of reporting a red. Use Assert.True with a message.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-29 13:50:41 +02:00
commit 91ed4ef91b
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/Aetheria.Shared.Tests/FireControlCut124Tests.cs
View file

@ -1299,7 +1299,7 @@ public sealed class FireControlCut124Tests : IDisposable
FireControl.Fire(e.Weapon, e.WeaponItem, e.Shooter);
var shot = Assert.Single(e.Zone.PendingShots);
Assert.Null(shot.Target);
Assert.True(shot.Target == null, "an invalid target must not ride with the round"); // not Assert.Null: a failure would format the entity graph and overflow the stack
Assert.Equal(burst.x, shot.BurstPosition.x, 3);
Assert.Equal(burst.z, shot.BurstPosition.z, 3);
e.Zone.Update(.01f);
@ -1478,7 +1478,7 @@ public sealed class FireControlCut124Tests : IDisposable
var burst = PointAlong(e, normalize(float2(2, 1)), NoLockRange);
Assert.Equal(burst.x, committed.BurstPoint.x, 3);
Assert.Equal(burst.z, committed.BurstPoint.y, 3);
Assert.Same(committed, resolved);
Assert.True(ReferenceEquals(committed, resolved), "the resolution republishes the commit unchanged");
}
// ToWorldPoint and ToSchematicPoint are inverses, and ToWorldPoint puts one cell to starboard of the centre