From 51fc64de31918ebef4d5081aa7ceeb544e942fa3 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Sat, 17 Oct 2026 16:22:01 +0200 Subject: [PATCH] Tests: Pirates allegiance count is the other factions' count, not 12; gear draw seeds spread by a hash Co-Authored-By: Claude Opus 5.5 --- tests/Aetheria.Shared.Tests/MinorPowersTests.cs | 3 ++- .../Aetheria.Shared.Tests/PiratesFactionCommandTests.cs | 9 ++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/Aetheria.Shared.Tests/MinorPowersTests.cs b/tests/Aetheria.Shared.Tests/MinorPowersTests.cs index 89e77844b..7416f08df 100644 --- a/tests/Aetheria.Shared.Tests/MinorPowersTests.cs +++ b/tests/Aetheria.Shared.Tests/MinorPowersTests.cs @@ -135,7 +135,8 @@ public sealed partial class RunStartTests return new LoadoutGenerator(ref _items.Random, _items, _galaxy, _galaxy.Entrance, factions.Single(f => f.ShortName == shortName), .5f); } Assert.True(For("AU", 1).IsAvailable(pattern30)); - Assert.Contains(Enumerable.Range(1, 64), seed => For("AU", (uint) seed).ChooseProduct(autocannon)?.Name == pattern30.Name); + // Seeds 1-64 spread by a multiplicative hash: the generator's first draws of adjacent small seeds are close together. + Assert.Contains(Enumerable.Range(1, 64), seed => For("AU", unchecked((uint) seed * 2654435761u)).ChooseProduct(autocannon)?.Name == pattern30.Name); var terri = For("Miss Terri's", 1); var theirs = _cache.GetAll().Where(p => new[] { "Aya", "Megiddo", "Forge" }.Contains(_cache.Get(p.Manufacturer).ShortName)).ToArray(); diff --git a/tests/Aetheria.Shared.Tests/PiratesFactionCommandTests.cs b/tests/Aetheria.Shared.Tests/PiratesFactionCommandTests.cs index 67e91bde1..0a3cb161d 100644 --- a/tests/Aetheria.Shared.Tests/PiratesFactionCommandTests.cs +++ b/tests/Aetheria.Shared.Tests/PiratesFactionCommandTests.cs @@ -39,6 +39,13 @@ public sealed class PiratesFactionCommandTests : IDisposable public void Dispose() => Directory.Delete(_root, true); + private int AllFactionsButThePirates() + { + var db = AetherDb.Open(root: _root); + try { return db.Cache.GetAll().Count(f => f.Name != "Pirates"); } + finally { db.Cache.Dispose(); } + } + private (Faction[] Pirates, FactionProductData[] Products) Read() { var db = AetherDb.Open(root: _root); @@ -69,7 +76,7 @@ public sealed class PiratesFactionCommandTests : IDisposable Assert.Equal(3, faction.InfluenceDistance); Assert.Equal(new CultMath.float3(.42f, .40f, .37f), faction.PrimaryColor); Assert.Equal(new CultMath.float3(1f, .45f, .05f), faction.SecondaryColor); - Assert.Equal(12, faction.Allegiance.Count); + Assert.Equal(AllFactionsButThePirates(), faction.Allegiance.Count); Assert.All(faction.Allegiance.Values, value => Assert.Equal(1f, value)); var db = AetherDb.Open(root: _root);