diff --git a/Assets/Scripts/Editor/MapBeltPerf.cs b/Assets/Scripts/Editor/MapBeltPerf.cs index 50b002471..7e4e5a594 100644 --- a/Assets/Scripts/Editor/MapBeltPerf.cs +++ b/Assets/Scripts/Editor/MapBeltPerf.cs @@ -9,13 +9,15 @@ using UnityEngine; using float4 = CultMath.float4; using Debug = UnityEngine.Debug; -// The map's belt cost per frame, CPU milliseconds and managed allocation: MapPresenter's belt upload and draw for belts of -// 1000, 4000 and 10000 asteroids (a generated belt holds 11 + sqrt(mass * distance), Settings.asset). Needs a GPU device. +// The map's belt cost per frame, CPU milliseconds and managed allocation, for belts of 1000, 2250 (the generated +// maximum, Settings.asset) and 4000 asteroids: the base revision's AsteroidBeltUI.Update (MapBeltPerfBase, a verbatim copy) +// and MapPresenter's belt upload and draw, each as the median and interquartile range of 21 runs of 300 frames after +// a warm-up, in this one Unity job. CPU time only: GPU cost is not covered. Needs a GPU device. // // Unity -batchmode -projectPath -executeMethod MapBeltPerf.Run -logFile public static class MapBeltPerf { - private const int Warmup = 60, Frames = 600; + private const int Warmup = 60, Frames = 300, RunCount = 21; public static void Run() { @@ -23,7 +25,7 @@ public static class MapBeltPerf try { Directory.CreateDirectory(work); - foreach (var count in new[] { 1000, 4000, 10000 }) Measure(work, count); + foreach (var count in new[] { 1000, 2250, 4000 }) Measure(work, count); EditorApplication.Exit(0); } catch (Exception exception) @@ -61,24 +63,55 @@ public static class MapBeltPerf }, pack, new GalaxyZone { Name = "Perf", Owner = null }, null); var transforms = new float4[count]; - // BEGIN MEASURED SETUP var presenter = new MapPresenter(new Material[0], AssetDatabase.LoadAssetAtPath("Assets/Materials/UI/MapAsteroid.mat"), 4, 4, 3f); presenter.BeltsOnMinimap = true; presenter.RegisterBelt(beltKey, transforms); - // END MEASURED SETUP + var baseBelt = new MapBeltPerfBase(zone, zone.AsteroidBelts[beltKey], 4, 4, 3f); + + Report("base", count, Runs(zone, beltKey, transforms, () => baseBelt.Update(transforms, 0f))); + Report("head", count, Runs(zone, beltKey, transforms, () => presenter.Draw(zone, 0))); + presenter.Clear(); + } + + // Each run is Frames frames after Warmup frames; the figure is one run's CPU ms per frame and managed bytes per frame. + private static (double ms, long bytes)[] Runs(Zone zone, CultRecordKey beltKey, float4[] transforms, Action frame) + { + var results = new (double, long)[RunCount]; var stopwatch = new Stopwatch(); - long allocated = 0; - for (var frame = 0; frame < Warmup + Frames; frame++) + var time = 0.0; + for (var run = -1; run < RunCount; run++) { - zone.EvaluateBelt(beltKey, transforms, 0.016 * frame); - var bytes = GC.GetAllocatedBytesForCurrentThread(); - if (frame >= Warmup) stopwatch.Start(); - // BEGIN MEASURED FRAME - presenter.Draw(zone, 0); - // END MEASURED FRAME - if (frame >= Warmup) stopwatch.Stop(); - if (frame >= Warmup) allocated += GC.GetAllocatedBytesForCurrentThread() - bytes; + stopwatch.Reset(); + long allocated = 0; + for (var i = 0; i < Warmup + Frames; i++) + { + zone.EvaluateBelt(beltKey, transforms, time += 0.016); + var bytes = GC.GetAllocatedBytesForCurrentThread(); + if (i >= Warmup) stopwatch.Start(); + frame(); + if (i >= Warmup) stopwatch.Stop(); + if (i >= Warmup) allocated += GC.GetAllocatedBytesForCurrentThread() - bytes; + } + if (run >= 0) results[run] = (stopwatch.Elapsed.TotalMilliseconds / Frames, allocated / Frames); } - Debug.Log($"[MapBeltPerf] asteroids={count} cpu_ms_per_frame={stopwatch.Elapsed.TotalMilliseconds / Frames:F4} gc_bytes_per_frame={allocated / Frames}"); + return results; + } + + private static double Quantile(double[] sorted, double q) + { + var at = q * (sorted.Length - 1); + var low = (int)Math.Floor(at); + var high = Math.Min(low + 1, sorted.Length - 1); + return sorted[low] + (sorted[high] - sorted[low]) * (at - low); + } + + private static void Report(string revision, int count, (double ms, long bytes)[] runs) + { + var ms = runs.Select(r => r.ms).OrderBy(v => v).ToArray(); + var bytes = runs.Select(r => (double)r.bytes).OrderBy(v => v).ToArray(); + var units = Process.GetProcessesByName("Unity").Length; + Debug.Log($"[MapBeltPerf] revision={revision} asteroids={count} runs={runs.Length} frames_per_run={Frames} " + + $"cpu_ms_median={Quantile(ms, .5):F4} iqr={Quantile(ms, .25):F4}-{Quantile(ms, .75):F4} " + + $"gc_bytes_median={Quantile(bytes, .5):F0} unity_processes={units} cpus={Environment.ProcessorCount}"); } } diff --git a/Assets/Scripts/Editor/MapBeltPerfBase.cs b/Assets/Scripts/Editor/MapBeltPerfBase.cs new file mode 100644 index 000000000..6470b9c9a --- /dev/null +++ b/Assets/Scripts/Editor/MapBeltPerfBase.cs @@ -0,0 +1,88 @@ +using GameCult.Caching; +using CultMath; +using UnityEngine; +using static CultMath.math; +using float2 = CultMath.float2; +using float4 = CultMath.float4; +using Random = UnityEngine.Random; + +// The base revision's per-frame belt map path, copied from ZoneRenderer.cs at da6fe033 (class AsteroidBeltUI) so that +// MapBeltPerf can measure it beside MapPresenter in one job. Only the lead it read from ActionGameManager.Clock is +// fixed at zero. Not used by the game. +public class MapBeltPerfBase +{ + private Vector3[] _vertices; + private Vector3[] _normals; + private Vector2[] _uvs; + private int[] _indices; + private CultRecordKey _orbitParent; + private Mesh _mesh; + private float _size; + private Zone _zone; + private AsteroidBelt _belt; + private float _scale; + + public MapBeltPerfBase(Zone zone, AsteroidBelt belt, int spritesheetWidth, int spritesheetHeight, float scale) + { + _belt = belt; + _zone = zone; + var orbit = zone.Orbits[belt.Data.Orbit.Key]; + _orbitParent = orbit.Data.Parent.Key; + _vertices = new Vector3[_belt.Data.Asteroids.Length * 4]; + _normals = new Vector3[_belt.Data.Asteroids.Length * 4]; + _uvs = new Vector2[_belt.Data.Asteroids.Length * 4]; + _indices = new int[_belt.Data.Asteroids.Length * 6]; + _scale = scale; + + var maxDist = 0f; + var spriteSize = float2(1f / spritesheetWidth, 1f / spritesheetHeight); + // vertex order: bottom left, top left, top right, bottom right + for (var i = 0; i < belt.Data.Asteroids.Length; i++) + { + if (belt.Data.Asteroids[i].Distance > maxDist) + maxDist = belt.Data.Asteroids[i].Distance; + var spriteX = Random.Range(0, spritesheetWidth); + var spriteY = Random.Range(0, spritesheetHeight); + + _uvs[i * 4] = new Vector2(spriteX * spriteSize.x, spriteY * spriteSize.y); + _uvs[i * 4 + 1] = new Vector2(spriteX * spriteSize.x, spriteY * spriteSize.y + spriteSize.y); + _uvs[i * 4 + 2] = new Vector2(spriteX * spriteSize.x + spriteSize.x, spriteY * spriteSize.y + spriteSize.y); + _uvs[i * 4 + 3] = new Vector2(spriteX * spriteSize.x + spriteSize.x, spriteY * spriteSize.y); + + _indices[i * 6] = i * 4; + _indices[i * 6 + 1] = i * 4 + 1; + _indices[i * 6 + 2] = i * 4 + 3; + _indices[i * 6 + 3] = i * 4 + 3; + _indices[i * 6 + 4] = i * 4 + 1; + _indices[i * 6 + 5] = i * 4 + 2; + } + + for (var i = 0; i < _normals.Length; i++) _normals[i] = -Vector3.forward; + + _mesh = new Mesh(); + _mesh.vertices = _vertices; + _mesh.uv = _uvs; + _mesh.triangles = _indices; + _mesh.normals = _normals; + _mesh.bounds = new Bounds(Vector3.zero, Vector3.one * maxDist); + _size = maxDist; + } + + public void Update(float4[] transforms, float height) + { + var parentPosition = DrawAhead.Orbit(_zone, _orbitParent, 0f); + for (var i = 0; i < transforms.Length; i++) + { + var transform = transforms[i]; + var rotation = Quaternion.Euler(90, transform.z, 0); + var position = new Vector3(transform.x, height, transform.y); + _vertices[i * 4] = rotation * new Vector3(-transform.w * _scale, -transform.w * _scale, 0) + position; + _vertices[i * 4 + 1] = rotation * new Vector3(-transform.w * _scale, transform.w * _scale, 0) + position; + _vertices[i * 4 + 2] = rotation * new Vector3(transform.w * _scale, transform.w * _scale, 0) + position; + _vertices[i * 4 + 3] = rotation * new Vector3(transform.w * _scale, -transform.w * _scale, 0) + position; + } + + _mesh.bounds = new Bounds(new Vector3(parentPosition.x, 0, parentPosition.y), Vector3.one * (_size * 2)); + _mesh.vertices = _vertices; + } +} diff --git a/Assets/Scripts/Editor/MapBeltPerfBase.cs.meta b/Assets/Scripts/Editor/MapBeltPerfBase.cs.meta new file mode 100644 index 000000000..662341fb1 --- /dev/null +++ b/Assets/Scripts/Editor/MapBeltPerfBase.cs.meta @@ -0,0 +1,2 @@ +fileFormatVersion: 2 +guid: c3e6b631c94f2384c87cf1906907af9f \ No newline at end of file diff --git a/Assets/Scripts/Editor/MapPresenterCapture.cs b/Assets/Scripts/Editor/MapPresenterCapture.cs new file mode 100644 index 000000000..1e0a727f0 --- /dev/null +++ b/Assets/Scripts/Editor/MapPresenterCapture.cs @@ -0,0 +1,119 @@ +using System; +using System.IO; +using UnityEditor; +using UnityEditor.SceneManagement; +using UnityEngine; + +// Proof that a planet icon and a ping tint reach the pixels of the real map cameras when the planet's well is deeper +// than 1000 below the camera. The ARPG scene's own "Map Overlays" and "Map Tint" cameras (position, orthographic size, +// clip planes and culling mask as authored) render into a render texture on a solid black background. For each, in +// order: a control render with nothing drawn; a render with the thing placed 1100 below the camera (a plain quad, and the +// PingEffect prefab), which must equal the control because the far plane clips it; then MapPresenter's draw of the sun +// (well deeper than 2000) or the PingEffect prefab placed where EntityInstance places it, which must differ from the +// control at its pixel. A capture that draws nothing fails the last check, and one that cannot tell drawn from clipped +// fails the middle one. +// +// Unity -batchmode -projectPath -executeMethod MapPresenterCapture.Run -logFile +// +// Needs a GPU device; do not pass -nographics or -quit: Run exits the Editor itself, 0 on success and 1 on any failure. +public static class MapPresenterCapture +{ + private const int Size = 64; + + public static void Run() + { + var work = Path.Combine(Path.GetTempPath(), $"map-presenter-capture-{Guid.NewGuid():N}"); + try + { + Directory.CreateDirectory(work); + Check(work); + Debug.Log("[MapPresenterCapture] ok"); + EditorApplication.Exit(0); + } + catch (Exception exception) + { + Debug.LogException(exception); + EditorApplication.Exit(1); + } + } + + private static void Require(bool condition, string what) + { + if (!condition) throw new InvalidOperationException(what); + } + + private static Camera SceneCamera(string name) + { + foreach (var camera in UnityEngine.Object.FindObjectsByType(FindObjectsInactive.Include, FindObjectsSortMode.None)) + if (camera.name == name) return camera; + throw new InvalidOperationException($"No camera named {name} in the scene."); + } + + private static Color Render(Camera camera, RenderTexture target, Vector3 at) + { + camera.targetTexture = target; + camera.clearFlags = CameraClearFlags.SolidColor; + camera.backgroundColor = Color.black; + camera.Render(); + var viewport = camera.WorldToViewportPoint(new Vector3(at.x, 0, at.z)); + var previous = RenderTexture.active; + RenderTexture.active = target; + var read = new Texture2D(Size, Size, TextureFormat.RGBA32, false); + read.ReadPixels(new Rect(0, 0, Size, Size), 0, 0); + RenderTexture.active = previous; + var pixel = read.GetPixel(Mathf.Clamp((int)(viewport.x * Size), 0, Size - 1), Mathf.Clamp((int)(viewport.y * Size), 0, Size - 1)); + UnityEngine.Object.DestroyImmediate(read); + return pixel; + } + + private static float Distance(Color a, Color b) => Mathf.Abs(a.r - b.r) + Mathf.Abs(a.g - b.g) + Mathf.Abs(a.b - b.b); + + private static void Check(string work) + { + EditorSceneManager.OpenScene("Assets/Scenes/ARPG.unity", OpenSceneMode.Single); + var f = MapPresenterSmoke.Build(work, flatIcons: true); + f.Map.SetMinimapScale(300f); + var target = new RenderTexture(Size, Size, 24, RenderTextureFormat.ARGB32); + var layer = LayerMask.NameToLayer("Minimap"); + + // Planet: the sun's icon through the map overlays camera. + var overlays = SceneCamera("Map Overlays"); + Require((overlays.cullingMask & (1 << layer)) != 0, "The Map Overlays camera does not see the Minimap layer."); + var well = f.Zone.GetHeight(DrawAhead.Orbit(f.Zone, f.Zone.PlanetInstances[f.SunKey].BodyData.Orbit.Key, 0), 0); + Require(well < -1000f, $"The fixture sun's well is {well}, not deeper than 1000."); + Require(f.Map.TryDrawn(f.SunKey, out var sun), "The sun registered no icon."); + var sunAt = sun.GetPosition(); + // Control: the pixel with nothing queued. Then a quad 1100 below the camera, deeper than the far plane, which must + // leave the pixel as it was. Then the presenter's draw, which must change it. Draws queue for the cameras that + // render after them, so the order is empty, deep, drawn. + var empty = Render(overlays, target, sunAt); + var quad = GameObject.CreatePrimitive(PrimitiveType.Quad); + var deepMesh = quad.GetComponent().sharedMesh; + var deepMaterial = new Material(Shader.Find("Unlit/Color")) { color = Color.white }; + UnityEngine.Object.DestroyImmediate(quad); + Graphics.RenderMesh(new RenderParams(deepMaterial) { layer = layer }, deepMesh, 0, + Matrix4x4.TRS(new Vector3(sunAt.x, -1100f, sunAt.z), Quaternion.Euler(90, 0, 0), Vector3.one * 300f)); + var deep = Render(overlays, target, sunAt); + Require(Distance(deep, empty) < .01f, $"A mesh 1100 below the camera drew: {deep} against {empty}."); + f.Map.Draw(f.Zone, 0); + var drawn = Render(overlays, target, sunAt); + Require(Distance(drawn, empty) > .3f, $"The sun's icon is not in the pixels: drawn {drawn}, empty {empty}."); + + // Ping tint: the PingEffect prefab where EntityInstance places it, through the map tint camera. + var tint = SceneCamera("Map Tint"); + var ping = (GameObject)PrefabUtility.InstantiatePrefab(AssetDatabase.LoadAssetAtPath("Assets/Content/Prefabs/PingEffect.prefab")); + ping.transform.localScale = Vector3.one * 300f; + var pingAt = new Vector3(sunAt.x, MapPresenter.PlaneY, sunAt.z); + ping.transform.position = pingAt; + ping.SetActive(false); + var untinted = Render(tint, target, pingAt); + ping.SetActive(true); + ping.transform.position = new Vector3(sunAt.x, -1100f, sunAt.z); + var deepPing = Render(tint, target, pingAt); + Require(Distance(deepPing, untinted) < .01f, $"A ping 1100 below the camera drew: {deepPing} against {untinted}."); + ping.transform.position = pingAt; + var tinted = Render(tint, target, pingAt); + Require(Distance(tinted, untinted) > .02f, $"The ping tint is not in the pixels: with {tinted}, without {untinted}."); + Debug.Log($"[MapPresenterCapture] well={well} sun drawn={drawn} empty={empty} deep={deep}; ping tinted={tinted} untinted={untinted} deep={deepPing}"); + } +} diff --git a/Assets/Scripts/Editor/MapPresenterCapture.cs.meta b/Assets/Scripts/Editor/MapPresenterCapture.cs.meta new file mode 100644 index 000000000..53caa5ee1 --- /dev/null +++ b/Assets/Scripts/Editor/MapPresenterCapture.cs.meta @@ -0,0 +1,2 @@ +fileFormatVersion: 2 +guid: cfa012aaae63b5044bdfd1b6b44ca9da \ No newline at end of file diff --git a/Assets/Scripts/Editor/MapPresenterSmoke.cs b/Assets/Scripts/Editor/MapPresenterSmoke.cs index b7c0e4ecb..8881880ed 100644 --- a/Assets/Scripts/Editor/MapPresenterSmoke.cs +++ b/Assets/Scripts/Editor/MapPresenterSmoke.cs @@ -51,17 +51,38 @@ public static class MapPresenterSmoke private static void Awaken(Component component) => component.GetType().GetMethod("Awake", Any)?.Invoke(component, null); - private static MeshRenderer NewIcon(Transform parent) + // flat: authored lying on the map plane (facing up), as a real icon is; the smoke's own icons are authored upright + // so that their rotation is exactly the yaw. + private static MeshRenderer NewIcon(Transform parent, bool flat) { var icon = GameObject.CreatePrimitive(PrimitiveType.Quad); icon.layer = LayerMask.NameToLayer("Minimap"); icon.transform.SetParent(parent, false); + if (flat) icon.transform.localRotation = Quaternion.Euler(90, 0, 0); var renderer = icon.GetComponent(); renderer.sharedMaterial = new Material(Shader.Find("Unlit/Color")) { color = new Color(1, 1, 1, .8f) }; return renderer; } + // What Build leaves registered with a presenter, for the checks here and for MapPresenterCapture. + internal sealed class Fixture + { + public Zone Zone; + public MapPresenter Map; + public Ship Ship, Other; + public EntityInstance ShipInstance, OtherInstance; + public CultRecordKey SunKey, BeltKey; + public float4[] Belt; + public Transform Roots; + } + private static void Check(string work) + { + var f = Build(work, flatIcons: false); + Checks(f); + } + + internal static Fixture Build(string work, bool flatIcons) { var settings = AssetDatabase.LoadAssetAtPath("Assets/Resources/Settings.asset") ?? throw new InvalidOperationException("No Settings.asset."); @@ -99,15 +120,19 @@ public static class MapPresenterSmoke var hullRef = items.ItemData.RefOf(items.ItemData.GetByName("Smoke Hull")); var ship = new Ship(items, zone, new EquippableItem { Data = hullRef, Durability = 1000, Lot = 1 }, new EntitySettings()); var other = new Ship(items, zone, new EquippableItem { Data = hullRef, Durability = 1000, Lot = 2 }, new EntitySettings()); - ship.Position = float3(300, 0, 200); - other.Position = float3(-300, 0, 100); + ship.Position = float3(300, 50, 200); + other.Position = float3(-300, -90, 100); zone.Admit(ship, piloted: false); zone.Admit(other, piloted: false); - // A hull rolled 30 and pitched 20 degrees, heading 40 degrees from +z: Direction is the heading, Rotation the full pose. - var heading = Quaternion.Euler(0, 40, 0); - var forward = heading * Quaternion.Euler(-20, 0, 0) * Vector3.forward; - var pose = Quaternion.LookRotation(forward, Quaternion.AngleAxis(30, forward) * Vector3.up); + // A hull heading 40 degrees from +z, pitched up 89.9 and rolled 30: its forward is almost vertical, where the pose's + // eulerAngles.y is the gimbal decomposition (yaw and roll folded together), not the heading. The heading is the + // forward projected onto the map plane, 40. The fixture asserts the two differ, so a yaw read from eulerAngles + // cannot pass. + var pose = Quaternion.Euler(0, 40, 0) * Quaternion.Euler(-89.9f, 0, 30); + var flatForward = pose * Vector3.forward; + Require(Mathf.Abs(Mathf.DeltaAngle(Mathf.Atan2(flatForward.x, flatForward.z) * Mathf.Rad2Deg, 40f)) < .5f, "The fixture's forward does not head 40."); + Require(Mathf.Abs(Mathf.DeltaAngle(pose.eulerAngles.y, 40f)) > 10f, $"The fixture's eulerAngles.y {pose.eulerAngles.y} is aligned with its heading."); ship.Direction = float2(Mathf.Sin(40 * Mathf.Deg2Rad), Mathf.Cos(40 * Mathf.Deg2Rad)); typeof(Ship).GetProperty("Rotation", Any).GetSetMethod(true).Invoke(ship, new object[] { new CultMath.quaternion(pose.x, pose.y, pose.z, pose.w) }); @@ -124,7 +149,7 @@ public static class MapPresenterSmoke instance.ThrusterHardpoints = new ThrusterHardpoint[0]; instance.WeaponHardpoints = new WeaponHardpoint[0]; instance.ArticulationPoints = new ArticulationPoint[0]; - instance.MapIcon = NewIcon(body.transform); + instance.MapIcon = NewIcon(body.transform, flatIcons); var zoneRenderer = new GameObject("Smoke Zone Renderer").AddComponent(); zoneRenderer.Settings = settings; zoneRenderer.MapGravityMaterials = new Material[0]; @@ -137,7 +162,7 @@ public static class MapPresenterSmoke var otherInstance = Bound(other); var sunRoot = new GameObject("Smoke Sun").transform; sunRoot.SetParent(roots); - map.RegisterPlanet(sunKey, NewIcon(sunRoot), sunRoot); + map.RegisterPlanet(sunKey, NewIcon(sunRoot, flatIcons), sunRoot); var belt = new float4[Asteroids]; map.RegisterBelt(beltKey, belt); zone.EvaluateBelt(beltKey, belt, DrawAhead.Time(zone, 0)); @@ -146,12 +171,13 @@ public static class MapPresenterSmoke map.SetFade(other, 1f); map.SetMinimapScale(2f); map.Draw(zone, 0); - Checks(zone, map, ship, other, shipInstance, otherInstance, sunKey, beltKey, belt, roots); + return new Fixture { Zone = zone, Map = map, Ship = ship, Other = other, ShipInstance = shipInstance, + OtherInstance = otherInstance, SunKey = sunKey, BeltKey = beltKey, Belt = belt, Roots = roots }; } - private static void Checks(Zone zone, MapPresenter map, Ship ship, Ship other, EntityInstance shipInstance, - EntityInstance otherInstance, CultRecordKey sunKey, CultRecordKey beltKey, float4[] belt, Transform roots) + private static void Checks(Fixture f) { + var (zone, map, ship, other, sunKey, beltKey, belt, roots) = (f.Zone, f.Map, f.Ship, f.Other, f.SunKey, f.BeltKey, f.Belt, f.Roots); // Deep planet: the sun's field is deeper than 2000 below the plane, and its icon sits on the map plane inside both // map cameras' clip range (minimap at y 10, map screen at y 1; near 0.3, far 1000, looking down). var well = zone.GetHeight(DrawAhead.Orbit(zone, zone.PlanetInstances[sunKey].BodyData.Orbit.Key, 0), 0); @@ -160,8 +186,22 @@ public static class MapPresenterSmoke var y = sunIcon.GetPosition().y; Require(y < 1f - .3f && y > 10f - 1000f && Mathf.Abs(y - MapPresenter.PlaneY) < .5f, $"The sun's icon is drawn at y {y}, not on the map plane."); - // Tilted hull: the icon turns by yaw 40 about up, times its authored rotation (identity here), with no roll or pitch. + // Axes: each icon sits at its sim position's planar x and z (a ship at (300, 200), the other at (-300, 100), the sun at + // its orbit), never swapped, and never at the 3D height (the ships ride at y 50 and -90, the sun's well is below -2000). + var shipAt = DrawAhead.Position(ship, 0); + Require(Mathf.Abs(shipAt.x - 300f) < 1e-3f && Mathf.Abs(shipAt.z - 200f) < 1e-3f, $"The ship's sim position is ({shipAt.x}, {shipAt.z}), not (300, 200)."); + var sunAt = DrawAhead.Orbit(zone, zone.PlanetInstances[sunKey].BodyData.Orbit.Key, 0); Require(map.TryDrawn(ship, out var shipIcon, out _), "The ship registered no icon."); + Require(Mathf.Abs(shipIcon.GetPosition().x - 300f) < 1e-3f && Mathf.Abs(shipIcon.GetPosition().z - 200f) < 1e-3f, + $"The ship's icon is at ({shipIcon.GetPosition().x}, {shipIcon.GetPosition().z}), not its sim position (300, 200)."); + Require(map.TryDrawn(other, out var otherIcon, out _), "The second ship registered no icon."); + Require(Mathf.Abs(otherIcon.GetPosition().x + 300f) < 1e-3f && Mathf.Abs(otherIcon.GetPosition().z - 100f) < 1e-3f, + $"The second ship's icon is at ({otherIcon.GetPosition().x}, {otherIcon.GetPosition().z}), not (-300, 100)."); + Require(Mathf.Abs(sunIcon.GetPosition().x - sunAt.x) < 1e-3f && Mathf.Abs(sunIcon.GetPosition().z - sunAt.y) < 1e-3f, + $"The sun's icon is at ({sunIcon.GetPosition().x}, {sunIcon.GetPosition().z}), not its orbit ({sunAt.x}, {sunAt.y})."); + Require(Mathf.Abs(otherIcon.GetPosition().y - (MapPresenter.PlaneY + MapPresenter.ShipOffset)) < 1e-4f, "The second ship's icon took the 3D height."); + + // Tilted hull: the icon turns by the heading projected onto the map plane (40) times its authored rotation (identity here), with no roll or pitch. var want = Quaternion.Euler(0, 40, 0); Require(Quaternion.Angle(shipIcon.rotation, want) < .1f, $"The icon is rotated {shipIcon.rotation.eulerAngles}, not yaw 40 alone."); Require(Vector3.Angle(shipIcon.rotation * Vector3.up, Vector3.up) < .1f, "The icon's up axis tilted with the hull.");