Credits: credit the works whose notice is only a source header; test scans headers

Commit 16cb82d09 said every third-party work whose own text states holder and licence
was credited. That was false: header-only notices were missed. Now credited, holder
and licence taken from each file's own text: Academy of Motion Picture Arts and
Sciences (ACES.hlsl, 2015), Unity Technologies 2016 MIT (the built-in shader sources
Particle Standard Unlit, StretchedSkybox, MaskedWorldSpaceUI, MaskedWorldSpaceAdditiveUI
and the three AdditiveUI shaders), Supyrb 2017 (AdditiveUI shaders; the header states
no licence for that portion), and Stefan Gustavson 2011 MIT (Celestial Body
SimplexNoise2.cginc).

The discovery test now also scans every Copyright line in .shader/.hlsl/.cginc/.cs/.compute
under Assets; its holder must appear in a credit notice or in ReviewedHeaders with the
reason. Microsoft Open Technologies (UniRx headers, no licence stated, points at a
License.txt that is not in the repo) is the one reviewed entry. The Unity headers point
at a license.txt that is likewise not in the repo.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Nibu 2026-11-12 16:16:25 +00:00
commit 43be42fb52
2 changed files with 89 additions and 2 deletions

View file

@ -27,6 +27,11 @@ public static class Credits
public const string AmbientCgFile = "Assets/Materials/PBR/SOURCES.md";
public const string KdTreeFile = "Assets/Scripts/ServerShared/NIH/KDTree/KDTree.cs";
public const string SimplexNoiseFile = "Assets/Plugins/GPU Noise/SimplexNoise2D.cginc";
// Works whose notice is only a source-file header; each answers through the file whose header states it.
public const string UnityShaderFile = "Assets/Shaders/Particle Standard Unlit.shader";
public const string AdditiveUiFile = "Assets/Shaders/AdditiveUI.shader";
public const string AcesFile = "Assets/Shaders/CustomDoF/ACES.hlsl";
public const string ClassicNoiseFile = "Assets/Plugins/Celestial Body/Scripts/Shaders/Includes/SimplexNoise2.cginc";
// The first line of the attribution file; the icon credits are the lines after it.
public const string NounProjectHeading = "Noun Project";
// Where the player build loads the Noun Project credit lines from (Resources path, no extension).
@ -100,6 +105,39 @@ public static class Credits
LicenceFile = SimplexNoiseFile
},
new Credit
{
Name = "Celestial Body noise shaders",
Licence = "MIT",
Notice = "Copyright (C) 2011 Ashima Arts. Copyright (C) 2011 by Ashima Arts (Simplex noise). " +
"Copyright (C) 2011 by Stefan Gustavson (Classic noise).",
LicenceFile = ClassicNoiseFile
},
new Credit
{
Name = "Unity built-in shaders",
Licence = "MIT",
Notice = "Copyright (c) 2016 Unity Technologies. Shader source adapted from Unity's built-in shaders " +
"(Particle Standard Unlit, StretchedSkybox, MaskedWorldSpaceUI, MaskedWorldSpaceAdditiveUI).",
LicenceFile = UnityShaderFile
},
new Credit
{
Name = "AdditiveUI shaders",
Licence = "MIT for the Unity Technologies portion; the Supyrb portion states no licence",
Notice = "Copyright (c) 2017 Supyrb. All rights reserved. Author: Johannes Deml. " +
"Built on Unity's built-in UI shader, copyright (c) 2016 Unity Technologies, MIT.",
LicenceFile = AdditiveUiFile
},
new Credit
{
Name = "ACES colour transforms",
Licence = "Academy Color Encoding System licence",
Notice = "Copyright 2015 Academy of Motion Picture Arts and Sciences (A.M.P.A.S.). " +
"Portions contributed by others as indicated. All rights reserved. " +
"Source: https://github.com/ampas/aces-dev",
LicenceFile = AcesFile
},
new Credit
{
Name = "ambientCG PBR materials",
Licence = "CC0 1.0 Universal",