From 2b8b604549d26e1595a77e7d842e1f8ebed32bc7 Mon Sep 17 00:00:00 2001
From: Meta Vens <rwvens@hotmail.com>
Date: Mon, 29 Jun 2026 07:55:04 +0100
Subject: [PATCH] Remove generic Unity reactive provider access

---
 Aetheria.State.Verify/Program.cs              | 17 ++++-
 .../AetheriaUnityRuntimeClientProvider.cs     | 65 -------------------
 2 files changed, 14 insertions(+), 68 deletions(-)

diff --git a/Aetheria.State.Verify/Program.cs b/Aetheria.State.Verify/Program.cs
index 25585dbec..a1c490cd6 100644
--- a/Aetheria.State.Verify/Program.cs
+++ b/Aetheria.State.Verify/Program.cs
@@ -16370,7 +16370,6 @@ static void RequireRuntimeStateReaderOwnsUnityStateAcquisition(string root)
         "public static AetheriaControl Control(string runtimeId = \"\")",
         "public static AetheriaUi Ui(string runtimeId = \"\")",
         "public static AetheriaUi Ui(",
-        "public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(string runtimeId = \"\")",
         "public static CultMeshReactiveDocument<AetheriaRuntimeCurrentDockingDocument> ReactiveCurrentDocking(",
         "public static CultMeshReactiveDocument<AetheriaRuntimeCurrentEntityDocument> ReactiveCurrentEntity(",
         "public static CultMeshReactiveDocument<AetheriaRuntimeStationRefitDocument> ReactiveStationRefit(",
@@ -16384,9 +16383,15 @@ static void RequireRuntimeStateReaderOwnsUnityStateAcquisition(string root)
         "public static CultMeshReactiveDocument<AetheriaRuntimeCurrentZoneDocument> ReactiveCurrentZone(",
         "public static CultMeshReactiveDocument<AetheriaRuntimeZoneContactsDocument> ReactiveZoneContacts(",
         "public static CultMeshReactiveDocument<AetheriaRuntimeVerseHostSettingsDocument> ReactiveVerseHostSettings(",
-        "public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(",
-        "AetheriaClientEveSurface surface",
         "public static CultMeshReactiveDocument<global::Aetheria.State.Documents.EveSurfaceState> ReactiveEveSurface(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeRtsViewportDocument> ReactiveRtsViewport(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeObjectsViewportDocument> ReactiveObjectsViewport(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeGravityViewportDocument> ReactiveGravityViewport(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeRenderSplatsViewportDocument> ReactiveRenderSplatsViewport(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeZoneDetailsDocument> ReactiveZoneDetails(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeSelectedObjectDocument> ReactiveSelectedObject(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeInventoryDocument> ReactiveInventory(",
+        "public static CultMeshReactiveDocument<AetheriaRuntimeStarbridgePlayerSeatDocument> ReactiveStarbridgePlayerSeat(",
         "public static CultMeshStateRefResolver EveSurfaceStateRefResolver(string runtimeId = \"\")",
         "public static CultMeshStateRefResolver EveSurfaceStateRefResolver(",
         "private static readonly Dictionary<string, AetheriaClient> RuntimeClients",
@@ -16411,6 +16416,12 @@ static void RequireRuntimeStateReaderOwnsUnityStateAcquisition(string root)
             string.Join(", ", missingRuntimeClientProviderSymbols));
     }
 
+    if (runtimeClientProvider.Contains("public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>", StringComparison.Ordinal))
+    {
+        throw new InvalidOperationException(
+            "AetheriaUnityRuntimeClientProvider must expose named game-state document access, not generic Reactive<TDocument> escape hatches.");
+    }
+
     if (runtimeClientProvider.Contains("AetheriaRuntimePlayerSettingsSession _playerSettingsDocument", StringComparison.Ordinal) ||
         runtimeClientProvider.Contains("public static AetheriaClient ResolveClient", StringComparison.Ordinal) ||
         runtimeClientProvider.Contains("public static AetheriaClient RuntimeClient", StringComparison.Ordinal) ||
diff --git a/Assets/Scripts/Gameplay/AetheriaUnityRuntimeClientProvider.cs b/Assets/Scripts/Gameplay/AetheriaUnityRuntimeClientProvider.cs
index 509fa9eb4..971a682e4 100644
--- a/Assets/Scripts/Gameplay/AetheriaUnityRuntimeClientProvider.cs
+++ b/Assets/Scripts/Gameplay/AetheriaUnityRuntimeClientProvider.cs
@@ -105,12 +105,6 @@ public static class AetheriaUnityRuntimeClientProvider
         return RuntimeClient(stateBoot, runtimeId).Ui;
     }
 
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(runtimeId).Reactive<TDocument>();
-    }
-
     public static CultMeshReactiveDocument<AetheriaRuntimeCurrentDockingDocument> ReactiveCurrentDocking(
         string runtimeId = "")
     {
@@ -280,31 +274,6 @@ public static class AetheriaUnityRuntimeClientProvider
         return RuntimeState(stateBoot, runtimeId).ReactiveVerseHostSettings();
     }
 
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaRuntimeStateBootReport stateBoot,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(stateBoot, runtimeId).Reactive<TDocument>();
-    }
-
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaClientEveSurface surface,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(runtimeId).Reactive<TDocument>(surface);
-    }
-
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaRuntimeStateBootReport stateBoot,
-        AetheriaClientEveSurface surface,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(stateBoot, runtimeId).Reactive<TDocument>(surface);
-    }
-
     public static CultMeshReactiveDocument<global::Aetheria.State.Documents.EveSurfaceState> ReactiveEveSurface(
         string surfaceId,
         string runtimeId = "")
@@ -320,23 +289,6 @@ public static class AetheriaUnityRuntimeClientProvider
         return RuntimeState(stateBoot, runtimeId).ReactiveEveSurface(surfaceId);
     }
 
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaRuntimeRtsViewportBounds viewport,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(runtimeId).Reactive<TDocument>(viewport);
-    }
-
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaRuntimeStateBootReport stateBoot,
-        AetheriaRuntimeRtsViewportBounds viewport,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(stateBoot, runtimeId).Reactive<TDocument>(viewport);
-    }
-
     public static CultMeshReactiveDocument<AetheriaRuntimeRtsViewportDocument> ReactiveRtsViewport(
         AetheriaRuntimeRtsViewportBounds viewport,
         string runtimeId = "")
@@ -397,23 +349,6 @@ public static class AetheriaUnityRuntimeClientProvider
         return RuntimeState(stateBoot, runtimeId).ReactiveRenderSplatsViewport(viewport);
     }
 
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        int index,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(runtimeId).Reactive<TDocument>(index);
-    }
-
-    public static CultMeshReactiveDocument<TDocument> Reactive<TDocument>(
-        AetheriaRuntimeStateBootReport stateBoot,
-        int index,
-        string runtimeId = "")
-        where TDocument : class
-    {
-        return RuntimeState(stateBoot, runtimeId).Reactive<TDocument>(index);
-    }
-
     public static CultMeshReactiveDocument<AetheriaRuntimeZoneDetailsDocument> ReactiveZoneDetails(
         int zoneIndex,
         string runtimeId = "")