GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

Fire control Cut 6c.1/6c.2: Resolution becomes reciprocal, targeting degrades instead of throwing

Browse source 
6c.1 (operator ruling 2026-09-19): Resolution stays a benefit -- higher is
better -- so HitProbability derives its sensor ceiling as the reciprocal of
Resolution instead of reading Resolution as the ceiling directly. The
authored 1-cell/2-cell targeting systems' Resolution values move to the new
scale in the next (data) commit.

6c.2: LoadoutGenerator.FillInterior no longer throws InvalidLoadoutException
when no targeting-system product is available to a galaxy -- it degrades to
no targeting system and logs the gap, safe only because Cut 5.1 already gave
unaided fire a floor (GameplaySettings.UnaidedTracking).

Adds FireControlCut6cTests.cs pinning both: HigherResolutionYieldsHigherOrEqualHitProbability
(dies if Resolution is read as the ceiling directly) and
NoSellerDegradesToUnaidedInsteadOfThrowing (dies if the throw is restored).

dotnet test tests/Aetheria.Shared.Tests: 210 passed, 0 failed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-19 18:31:46 +02:00
commit 29fcc3ee9e
4 changed files with 313 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Assets/Scripts/ServerShared/LoadoutGenerator.cs
View file

@ -263,20 +263,35 @@ public class LoadoutGenerator
// fire is a last resort, not an alternative loadout choice. EquipHardpoints runs before FillInterior
// (OutfitEntity), so entity.Weapons is already populated here. Zenith and anything else with no
// weapon hardpoints gets none.
//
// Cut 6c, 6c.2: this used to be `required: true` and throw InvalidLoadoutException when no seller was
// available -- a galaxy that happened not to draw a targeting design's manufacturer failed entity
// generation outright, a single point of failure the ten-seed smoke never sampled. It degrades instead:
// required: false, so RandomProducts' own manufacturer-widening fallback never fires and an unmet
// requirement returns null quietly rather than searching outside the galaxy for one. An entity that
// ends up with no targeting system fires through FireControl's unaided fallback
// (GameplaySettings.UnaidedTracking, Cut 5.1) rather than not firing at all -- that floor is what makes
// this degrade safe. The gap is logged so it surfaces as content debt (AetherDb loadout reports it per
// seed) instead of vanishing silently.
if (entity.Weapons.Any())
{
emptyShape = entity.UnoccupiedSpace;
var (targetingProduct, targetingData) = RandomProduct<GearData>(2, item =>
item.Behaviors.Any(b => b is TargetingSystemData) &&
item.Shape.FitsWithin(emptyShape, out _, out _), required: true);
if (targetingData == null) throw new InvalidLoadoutException("No compatible targeting system found for entity!");
targetingData.Shape.FitsWithin(emptyShape, out var targetingRotation, out var targetingPosition);
var targetingSystem = ItemManager.CreateInstance(targetingProduct) as EquippableItem;
targetingSystem.Rotation = targetingRotation;
if (!entity.TryEquip(targetingSystem, targetingPosition))
throw new InvalidLoadoutException("Failed to equip selected targeting system!");
item.Shape.FitsWithin(emptyShape, out _, out _));
if (targetingData == null)
{
ItemManager.Log("No targeting system available for armed entity; it will fire unaided.");
}
else
{
targetingData.Shape.FitsWithin(emptyShape, out var targetingRotation, out var targetingPosition);
var targetingSystem = ItemManager.CreateInstance(targetingProduct) as EquippableItem;
targetingSystem.Rotation = targetingRotation;
if (!entity.TryEquip(targetingSystem, targetingPosition))
throw new InvalidLoadoutException("Failed to equip selected targeting system!");
}
}
}