GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

RecordSeenDestroyed allocates nothing in the common path

Browse source 
Sense runs for every pair of ships every tick: iterate Equipment by index and read
the believed layout only for an item actually perceived destroyed.
SenseAllocatesNothingOnceWarm failed on the previous commit (1257600 bytes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-15 04:57:13 +02:00
commit 22e1bc32cc
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Assets/Scripts/ServerShared/Entity.cs
View file

@ -1060,12 +1060,12 @@ public abstract class Entity
// record. The same PerceivesDestroyed Sense ends reveals by, applied to located mounts.
private void RecordSeenDestroyed(Entity subject)
{
_reveals.TryGetValue(subject, out var book);
var layout = LayoutOf(subject);
foreach (var item in subject.Equipment)
// Indexed, and the layout read only for an item actually perceived destroyed: Sense runs for every pair of ships every tick.
for (var i = 0; i < subject.Equipment.Count; i++)
{
var item = subject.Equipment[i];
if (item.Hardpoint == null || !PerceivesDestroyed(subject, item)) continue;
if (!layout.Contains(item.Hardpoint) && (book == null || !book.ContainsKey(item))) continue;
if (!LayoutOf(subject).Contains(item.Hardpoint) && !(_reveals.TryGetValue(subject, out var book) && book.ContainsKey(item))) continue;
if (!_seenDestroyed.TryGetValue(subject, out var seen)) _seenDestroyed[subject] = seen = new HashSet<HardpointData>();
seen.Add(item.Hardpoint);
}