From 0388e39913d8dc50a3a06b77a6aac173ffc045b2 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Mon, 12 Oct 2026 03:43:41 +0200 Subject: [PATCH] SmokeRoundsScenarioTests: the direct weapon's kill check counts a burst's rounds (Damage is per round, ammo per burst) Co-Authored-By: Claude Opus 5.5 --- tests/Aetheria.Shared.Tests/SmokeRoundsScenarioTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/Aetheria.Shared.Tests/SmokeRoundsScenarioTests.cs b/tests/Aetheria.Shared.Tests/SmokeRoundsScenarioTests.cs index f837e3d9f..eaf07de29 100644 --- a/tests/Aetheria.Shared.Tests/SmokeRoundsScenarioTests.cs +++ b/tests/Aetheria.Shared.Tests/SmokeRoundsScenarioTests.cs @@ -63,8 +63,9 @@ public sealed partial class RunStartTests Assert.True(Bears(direct, player, fragile), "the direct weapon cannot bear on the fragile hull"); Assert.True(length((fragile.Position - player.Position).xz) <= directWeapon.Range, "the fragile hull lies beyond the direct weapon's range"); var magazine = direct.Data.Behaviors.OfType().Single().MagazineSize; - Assert.True(magazine > 0 && directWeapon.Damage * magazine > ((HullData) _items.GetData(fragile.Hull)).Durability, - $"the direct weapon cannot kill the fragile hull from its magazine ({directWeapon.Damage} x {magazine})"); + var burst = ((InstantWeapon) directWeapon).BurstCount; + Assert.True(magazine > 0 && directWeapon.Damage * burst * magazine > ((HullData) _items.GetData(fragile.Hull)).Durability, + $"the direct weapon cannot kill the fragile hull from its magazine ({directWeapon.Damage} x {burst} x {magazine})"); // Only the Longinus at mid range is hostile. Assert.True(player.IsHostileTo(mid) && mid.IsHostileTo(player), "the mid-range hull is hostile");